Skip to content

Commit b586b12

Browse files
os-zhuangclaude
andauthored
ci(release): make live-hotcrm downstream smoke advisory during ADR-0090 v2 launch window (#2719)
The Release workflow's "Downstream backward-compat smoke (live hotcrm)" gate has been red on every main commit since ADR-0090 P1 (#2697), which removed the sharing recipients `role` / `role_and_subordinates` from @objectstack/spec with no compatibility aliases (docs/adr/0090 D3). The latest published hotcrm tag (v1.2.2) still authors those recipients, so the gate necessarily fails on a break the spec took deliberately, and no adopting hotcrm release exists yet to bump HOTCRM_REF to. Mark the step continue-on-error so it keeps running for signal but no longer blocks the v2 publish. Restore hard-blocking (drop the flag and bump HOTCRM_REF) once hotcrm ships a release on the v2 recipient vocabulary. Claude-Session: https://claude.ai/code/session_016ZGeuMQ4SeuCR4uaiWTUX5 Co-authored-by: Claude <noreply@anthropic.com>
1 parent 7a778c6 commit b586b12

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

.github/workflows/release.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,18 @@ jobs:
6262
run: bash scripts/build-console.sh
6363

6464
- name: Downstream backward-compat smoke (live hotcrm)
65+
# TEMPORARY (ADR-0090 v2 launch window) — advisory, not blocking.
66+
# ADR-0090 P1 (#2697) removed the sharing recipients `role` /
67+
# `role_and_subordinates` from @objectstack/spec with NO compatibility
68+
# aliases (docs/adr/0090 D3 — a deliberate, launch-window break). The
69+
# latest published hotcrm tag (v1.2.2) still authors those values, so
70+
# this gate necessarily goes red on a break the spec took on purpose,
71+
# and no adopting hotcrm release exists yet to bump HOTCRM_REF to. Keep
72+
# the step running for signal, but don't let it block the v2 publish.
73+
# RESTORE (make blocking again): once hotcrm ships a release adopting
74+
# the v2 recipient vocabulary, bump HOTCRM_REF below to that tag and
75+
# delete this `continue-on-error` line so a red here blocks publish.
76+
continue-on-error: true
6577
# Pre-publish gate (#2035): the about-to-publish @objectstack/spec must
6678
# not break a real third-party consumer pinned to a published release.
6779
# Clones objectstack-ai/hotcrm@${HOTCRM_REF}, installs it (published

0 commit comments

Comments
 (0)