fix(objectql): honor $searchFields override sent as a comma-string (ADR-0061) (#2159)

The $searchFields override (the view-level "narrow search to these fields"
signal that list views send) arrives over the REST/OData path as a URL query
param — i.e. a comma-separated STRING ("name,industry"), not an array. The
engine only applied it when Array.isArray was true, so the override was a
silent no-op: `search=tech&searchFields=name` still searched the default field
set instead of just `name`.

Coerce a string `requestedFields` to an array in resolveSearchFields (the single
seam), and pass the raw value through from engine.find. Now
`searchFields=name` narrows to the name field, `searchFields=industry` to
industry (matched via option label→value), as intended.

Verified end-to-end over HTTP: search "tech" with searchFields=name → only
Initech (name match); with searchFields=industry → the 4 Technology accounts.
Unit test added for the comma-string form.

Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: 3 people

packages/objectql/src/engine.ts

@@ -1916,7 +1916,7 @@ export class ObjectQL implements IDataEngine {
         const _searchFilter = expandSearchToFilter(_searchRaw, {
           fields: _findSchema.fields as any,
           searchableFields: (_findSchema as any).searchableFields,
-          requestedFields: Array.isArray(_reqFields) ? _reqFields : undefined,
+          requestedFields: _reqFields,
           displayField: (_findSchema as any).displayNameField,
         });
         if (_searchFilter) {

packages/objectql/src/search-filter.test.ts

@@ -55,6 +55,15 @@ describe('resolveSearchFields', () => {
     expect(f).toEqual(['industry']);
   });
 
+  it('accepts a comma-separated requestedFields string (URL param form)', () => {
+    const f = resolveSearchFields({
+      fields: accountFields,
+      searchableFields: ['name', 'industry', 'status'],
+      requestedFields: 'industry, status',
+    });
+    expect(f).toEqual(['industry', 'status']);
+  });
+
   it('ignores an override that resolves to nothing allowed (falls back)', () => {
     const f = resolveSearchFields({
       fields: accountFields,

packages/objectql/src/search-filter.ts

@@ -31,8 +31,10 @@ export interface ExpandSearchOptions {
   fields: Record<string, SearchFieldMeta>;
   /** Object-declared `searchableFields` (the canonical default set). */
   searchableFields?: string[];
-  /** Validated `$searchFields` override — intersected with the allowed set. */
-  requestedFields?: string[];
+  /** Validated `$searchFields` override — intersected with the allowed set.
+   *  Accepts an array or a comma-separated string (the form a URL query param
+   *  arrives as). */
+  requestedFields?: string | string[];
   /** Preferred display field, placed first in the auto-default. */
   displayField?: string;
 }
@@ -93,9 +95,12 @@ export function resolveSearchFields(opts: ExpandSearchOptions): string[] {
   const all = opts.fields || {};
   const declared = opts.searchableFields?.filter((f) => all[f]);
   const allowed = declared && declared.length > 0 ? declared : autoDefaultFields(all, opts.displayField);
-  if (opts.requestedFields && opts.requestedFields.length > 0) {
+  const requested = typeof opts.requestedFields === 'string'
+    ? opts.requestedFields.split(',').map((f) => f.trim()).filter(Boolean)
+    : opts.requestedFields;
+  if (requested && requested.length > 0) {
     const allowSet = new Set(allowed);
-    const validated = opts.requestedFields.filter((f) => allowSet.has(f));
+    const validated = requested.filter((f) => allowSet.has(f));
     if (validated.length > 0) return validated;
   }
   return allowed;