Skip to content

Commit c0c3883

Browse files
committed
ci: dogfood-verify 需构建示例 app 的完整依赖闭包
verify 步骤挂在 dogfood shard 1 时,workspace 已被测试步骤全量构建, --filter=@objectstack/cli 就够;独立成 job 后,打包的 objectstack.config 在运行时还要导入示例 app 自身的依赖(如 app-showcase 的 @objectstack/connector-mcp),其 dist 无人构建 → verify 时 ERR_MODULE_NOT_FOUND。改用 pkg... 闭包过滤同时构建 CLI 与两个示例 app 的依赖闭包,依赖变动时自维护。已本地实测 app-showcase verify 通过。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U8Ms7unkKxTrmNCX2r1dfs
1 parent 946e833 commit c0c3883

1 file changed

Lines changed: 12 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -676,9 +676,20 @@ jobs:
676676
- name: Install dependencies
677677
run: pnpm install --frozen-lockfile
678678

679+
# Build the CLI plus BOTH example apps' full dependency closures (the
680+
# `pkg...` filter form). When this pass rode dogfood shard 1 the whole
681+
# workspace was already built by the test step, so `--filter=@objectstack/cli`
682+
# alone sufficed; standalone, the bundled objectstack.config imports
683+
# runtime packages (e.g. @objectstack/connector-mcp for app-showcase)
684+
# whose dist nothing here had built — ERR_MODULE_NOT_FOUND at verify
685+
# time. The closure syntax keeps this self-maintaining as app deps move.
679686
- name: Verify example apps via the `objectstack verify` CLI
680687
run: |
681-
pnpm turbo run build --filter=@objectstack/cli --concurrency=4
688+
pnpm turbo run build \
689+
--filter=@objectstack/cli... \
690+
--filter=@objectstack/example-crm... \
691+
--filter=@objectstack/example-showcase... \
692+
--concurrency=4
682693
for app in examples/app-crm examples/app-showcase; do
683694
echo "::group::objectstack verify $app --rls"
684695
OS_LOG_LEVEL=error node packages/cli/bin/run.js verify --app "$app/objectstack.config.ts" --rls

0 commit comments

Comments
 (0)