Skip to content

Commit d1129c4

Browse files
os-zhuangclaude
andauthored
fix(deps): override undici to patched 7.28.0 to close GHSA-vmh5-mc38-953g (#2044)
CI's "Validate Package Dependencies" gate (pnpm audit --audit-level=high) fails on GHSA-vmh5-mc38-953g — undici TLS certificate validation bypass via dropped requestTls in the SOCKS5 ProxyAgent (vulnerable >=7.23.0 <7.28.0). undici 7.27.2 is pulled transitively through the VS Code extension's publish tooling: packages/vscode-objectstack > @vscode/vsce > cheerio > undici. Pin via pnpm-workspace.yaml `overrides` (the repo's canonical location — pnpm v10 ignores package.json `pnpm.overrides`). cheerio@1.2.0 declares undici ^7.19.0, so the override targets only the vulnerable range and forces ^7.28.0 (resolves to 7.28.0) — staying inside the 7.x major cheerio supports rather than jumping to undici 8.x. After the change `pnpm audit --audit-level=high` reports 0 high (exit 0) and `turbo run build --filter=objectstack-vscode` still succeeds. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent fd2e1a2 commit d1129c4

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

pnpm-lock.yaml

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,13 @@ onlyBuiltDependencies:
2424
# - form-data: GHSA-hmw2-7cc7-3qxx (high) — CRLF injection via unescaped
2525
# multipart field names. Pulled 4.0.5 transitively through @vscode/vsce;
2626
# force the patched >=4.0.6 line. Fails `pnpm audit --audit-level=high` (CI).
27+
# - undici: GHSA-vmh5-mc38-953g (high) — TLS cert validation bypass via
28+
# dropped requestTls in SOCKS5 ProxyAgent. Pulled 7.27.2 through
29+
# @vscode/vsce > cheerio (declares undici ^7.19.0); force the patched
30+
# 7.28.0 line (stays in the 7.x major cheerio supports). CI audit gate.
2731
overrides:
2832
esbuild: '>=0.28.1'
2933
'minimatch@<10.2.3': '10.2.3'
3034
'tar@>=2.0.0 <7.5.11': '^7.5.11'
3135
'form-data@<4.0.6': '>=4.0.6'
36+
'undici@>=7.23.0 <7.28.0': '^7.28.0'

0 commit comments

Comments
 (0)