Skip to content

Commit d752eba

Browse files
authored
Merge pull request #1717 from objectstack-ai/adr-0006-phase1-deprecate-cloud-dupes
docs(adr-0006): Phase 1 — mark framework cloud-plugin duplicates @deprecated
2 parents 3291633 + d0cb052 commit d752eba

5 files changed

Lines changed: 48 additions & 0 deletions

File tree

packages/runtime/src/cloud/cloud-url.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,13 @@
88
* Until we have a competing public hosted cloud, this points at the
99
* ObjectStack-operated control plane so a vanilla `objectstack dev` can
1010
* browse the marketplace out of the box.
11+
*
12+
* @deprecated ADR-0006 — framework's DUPLICATE copy. Canonical implementation
13+
* lives in cloud `@objectstack/objectos-runtime`
14+
* (`packages/objectos-runtime/src/cloud-url.ts`), which `apps/objectos` already
15+
* uses. **Still load-bearing**: the framework CLI `serve.ts` dynamically
16+
* imports `resolveCloudUrl` for cloud-dev serve mode — DO NOT DELETE until
17+
* ADR-0006 Phase 4 decouples the CLI (= ADR-0007 ⑤). Phase 1 declaration only.
1118
*/
1219
export const DEFAULT_CLOUD_URL = 'https://cloud.objectos.ai';
1320

packages/runtime/src/cloud/marketplace-install-local-plugin.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,16 @@ function safeFilename(manifestId: string): string {
8080
return manifestId.replace(/[^a-zA-Z0-9._-]/g, '_') + '.json';
8181
}
8282

83+
/**
84+
* @deprecated ADR-0006 / ADR-0007 ⑤ — framework's DUPLICATE copy. Canonical
85+
* implementation lives in cloud `@objectstack/objectos-runtime`
86+
* (`packages/objectos-runtime/src/marketplace-install-local-plugin.ts`), which
87+
* `apps/objectos` already uses and which is AHEAD of this copy (e.g. the
88+
* ADR-0036 `seeds:` rename). **Still load-bearing**: the framework CLI
89+
* `serve.ts` dynamically imports this for cloud-dev serve mode — DO NOT DELETE
90+
* until ADR-0006 Phase 4 decouples the CLI. Phase 1 is a declaration only:
91+
* no behavior change.
92+
*/
8393
export class MarketplaceInstallLocalPlugin implements Plugin {
8494
readonly name = 'com.objectstack.runtime.marketplace-install-local';
8595
readonly version = '1.0.0';

packages/runtime/src/cloud/marketplace-proxy-plugin.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,15 @@ export interface MarketplaceProxyPluginConfig {
145145
publicMarketplaceBaseUrl?: string;
146146
}
147147

148+
/**
149+
* @deprecated ADR-0006 — framework's DUPLICATE copy. Canonical implementation
150+
* lives in cloud `@objectstack/objectos-runtime`
151+
* (`packages/objectos-runtime/src/marketplace-proxy-plugin.ts`), which
152+
* `apps/objectos` already uses. **Still load-bearing**: the framework CLI
153+
* `serve.ts` dynamically imports this for cloud-dev serve mode — DO NOT DELETE
154+
* until ADR-0006 Phase 4 decouples the CLI (= ADR-0007 ⑤). Phase 1 is a
155+
* declaration only: no behavior change.
156+
*/
148157
export class MarketplaceProxyPlugin implements Plugin {
149158
readonly name = 'com.objectstack.runtime.marketplace-proxy';
150159
readonly version = '1.1.0';

packages/runtime/src/cloud/runtime-config-plugin.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,15 @@ export interface RuntimeConfigPluginConfig {
6565
productShortName?: string;
6666
}
6767

68+
/**
69+
* @deprecated ADR-0006 — framework's DUPLICATE copy. Canonical implementation
70+
* lives in cloud `@objectstack/objectos-runtime`
71+
* (`packages/objectos-runtime/src/runtime-config-plugin.ts`), which
72+
* `apps/objectos` already uses. **Still load-bearing**: the framework CLI
73+
* `serve.ts` dynamically imports this for cloud-dev serve mode — DO NOT DELETE
74+
* until ADR-0006 Phase 4 decouples the CLI (= ADR-0007 ⑤). Phase 1 is a
75+
* declaration only: no behavior change.
76+
*/
6877
export class RuntimeConfigPlugin implements Plugin {
6978
readonly name = 'com.objectstack.runtime.runtime-config';
7079
readonly version = '1.0.0';

packages/runtime/src/index.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,25 @@ export type { LoadArtifactBundleOptions } from './load-artifact-bundle.js';
100100
// (`@objectstack/objectos-runtime`). The framework keeps only the interface
101101
// contracts a host runtime needs to accept an externally-supplied
102102
// multi-tenant kernel router (see http-dispatcher's optional `kernelManager`).
103+
//
104+
// ADR-0006 Phase 1: the three plugins + cloud-url below are DUPLICATES of the
105+
// canonical copies in cloud `@objectstack/objectos-runtime`. They stay exported
106+
// and load-bearing (framework CLI cloud-dev serve) until ADR-0006 Phase 4
107+
// removes them (= ADR-0007 ⑤). `EnvironmentDriverRegistry` / `KernelManager`
108+
// are RETAINED contracts (D3) — not deprecated.
109+
/** @deprecated ADR-0006 — use cloud `@objectstack/objectos-runtime`. Removed in Phase 4. */
103110
export { MarketplaceProxyPlugin } from './cloud/marketplace-proxy-plugin.js';
111+
/** @deprecated ADR-0006 — use cloud `@objectstack/objectos-runtime`. Removed in Phase 4. */
104112
export type { MarketplaceProxyPluginConfig } from './cloud/marketplace-proxy-plugin.js';
113+
/** @deprecated ADR-0006 / ADR-0007 ⑤ — use cloud `@objectstack/objectos-runtime`. Removed in Phase 4. */
105114
export { MarketplaceInstallLocalPlugin } from './cloud/marketplace-install-local-plugin.js';
115+
/** @deprecated ADR-0006 / ADR-0007 ⑤ — use cloud `@objectstack/objectos-runtime`. Removed in Phase 4. */
106116
export type { MarketplaceInstallLocalPluginConfig } from './cloud/marketplace-install-local-plugin.js';
117+
/** @deprecated ADR-0006 — use cloud `@objectstack/objectos-runtime`. Removed in Phase 4. */
107118
export { RuntimeConfigPlugin } from './cloud/runtime-config-plugin.js';
119+
/** @deprecated ADR-0006 — use cloud `@objectstack/objectos-runtime`. Removed in Phase 4. */
108120
export type { RuntimeConfigPluginConfig } from './cloud/runtime-config-plugin.js';
121+
/** @deprecated ADR-0006 — use cloud `@objectstack/objectos-runtime`. Removed in Phase 4. */
109122
export { DEFAULT_CLOUD_URL, resolveCloudUrl } from './cloud/cloud-url.js';
110123
export type { EnvironmentDriverRegistry, KernelManager } from './cloud/environment-registry.js';
111124

0 commit comments

Comments
 (0)