Skip to content

Commit d839b25

Browse files
committed
feat(transport): prove the IHttpServer port is Hono-free — second adapter on raw node:http (ADR-0076 D11/OQ#10, #2462)
Multi-adapter was designed but unproven: only the Hono adapter existed, and ADR-0076 D11 flagged 'the normalized context shows Hono-isms' as a caveat blocking the transport decomposition. This adds the validation: - New @objectstack/plugin-node-server: a thin IHttpServer implementation on raw node:http with ZERO dependencies beyond @objectstack/core — :param + trailing-* routing (registration-order first-match, same as the primary adapter), eager JSON/urlencoded body parse with lazy rawBody() for binary, SSE via native res.write/end, 404/405-with-Allow semantics, EADDRINUSE retry, graceful drain on close. Deliberately no getRawApp()/mount(). - Cross-adapter conformance suite: boots the dispatcher bridge AND the REST route generator (with ObjectQL + memory driver) on BOTH adapters over real sockets — /data CRUD roundtrip, /meta reads, /ready, /health, discovery, :param routing, 404/405 parity, plus a probe-for-probe response-shape parity matrix between the two adapters. 40 assertions, all green. Findings recorded in ADR-0076 (OQ#9/OQ#10/OQ#11 resolution notes): - The port has NO hard Hono-isms. The Host-header backfill in the Hono adapter is a Fetch-API artifact local to that adapter, not a port leak. - All remaining Hono coupling is confined to the feature-detected getRawApp() escape hatch (metadata HMR, cloud-connection routes, static/SPA + CORS + Server-Timing) which degrades gracefully. - Follow-up for the D11 window: codify res.write/res.end (SSE) and getPort() — extensions consumers already rely on — plus 404/405 semantics into the IHttpServer contract. - OQ#9 audit verdict (delineate, don't merge; only discovery + packages are genuinely double-mounted) recorded in the ADR open-questions list. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A1BtxNeUaGmvUYr8FwtUNu
1 parent 55bc68d commit d839b25

14 files changed

Lines changed: 1172 additions & 3 deletions
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
---
2+
'@objectstack/plugin-node-server': minor
3+
---
4+
5+
feat(transport): second `IHttpServer` adapter on raw node:http — multi-adapter validation (ADR-0076 D11/OQ#10, #2462)
6+
7+
New package `@objectstack/plugin-node-server`: a thin, zero-dependency
8+
`node:http` implementation of the transport port (`IHttpServer`), plus a
9+
cross-adapter conformance suite that boots the dispatcher bridge and the
10+
REST route generator on BOTH this adapter and `plugin-hono-server` and
11+
asserts identical behavior over real sockets (full `/data` CRUD roundtrip,
12+
`:param` routing, 404/405 semantics, SSE streaming, discovery).
13+
14+
This resolves ADR-0076 OQ#10: the port is proven free of hard Hono-isms —
15+
all remaining Hono coupling is confined to the feature-detected
16+
`getRawApp()` escape hatch. Production deployments should keep using
17+
`plugin-hono-server`; this adapter targets the conformance suite and
18+
minimal embedding scenarios.

.changeset/config.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
"@objectstack/plugin-dev",
4141
"@objectstack/plugin-email",
4242
"@objectstack/plugin-hono-server",
43+
"@objectstack/plugin-node-server",
4344
"@objectstack/mcp",
4445
"@objectstack/plugin-pinyin-search",
4546
"@objectstack/plugin-reports",

docs/adr/0076-objectql-core-tiering.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,6 @@ import { SecurityPlugin } from '@objectstack/plugin-security';
204204
6. **Data-facade home** — does the `DataProtocol` impl live in the engine-adjacent transport layer / `rest`, or a small `@objectstack/protocol-data`? (It is thin and transport-shaped.)
205205
7. **Metadata package name (post-segmentation)****Resolved: keep `@objectstack/metadata-protocol`** (already published; renaming has ~0 benefit and real churn). The `protocol` suffix is a low-cost naming exception — the contract is in `@objectstack/spec/api`; a README note in the package should clarify impl-vs-contract.
206206
8. **Per-domain versioning** — once segmented, do capability protocols get independent version markers / a `getCapabilities()` discovery method?
207-
9. **dispatcher vs rest-server overlap**are `runtime/http-dispatcher` (~3.8k) and `rest/rest-server` (~5.1k) redundant central transport layers? Consolidate or delineate (D11).
208-
10. **Validate multi-adapter**write a second `IHttpServer` adapter (thin Workers/Express) to prove the port is free of Hono-isms before relying on it (D11).
209-
11. **D12 stub marker**standardise the self-identifying marker: reuse `_dev`, introduce `__stub: true`, or a richer per-service capability descriptor? (Decide when D12 is implemented.)
207+
9. **dispatcher vs rest-server overlap****Resolved (audit, #2462): delineate, do not merge.** They partition the API surface by domain rather than duplicating it: in a standard boot REST owns data/meta/batch/import-export/search/email/forms/sharing/reports/approvals/security, the dispatcher bridge owns mcp/ai/graphql/keys/automation/actions/storage/i18n/analytics/health/ready. Only **discovery** and **packages** are genuinely double-mounted (first-registration-wins — the D11 smell to fix), and the dispatcher's `/data`/`/meta`/`/ui`/`/notifications`/`/share-links`/`/security` `dispatch()` branches are **not mounted** in a standard boot (they are live only when `HttpDispatcher` is used directly as a callable by out-of-tree adapters). D11 worklist: (1) kill or delegate the dead callable branches; (2) give packages + discovery a single owner; (3) extract per-domain handlers; (4) unify env-resolution on the injected `KernelResolver` seam.
208+
10. **Validate multi-adapter****Resolved (validated, #2462): the port is free of hard Hono-isms.** A zero-dependency `node:http` adapter (`@objectstack/plugin-node-server`) runs the dispatcher bridge + REST generator unchanged; a cross-adapter conformance suite (40 assertions incl. `/data` CRUD roundtrip, `:param` routing, 404/405 semantics, SSE streaming, discovery) passes identically on both adapters. Findings: the Hono adapter's Host-header backfill is adapter-local (a Fetch-API artifact, not a port leak); all remaining Hono coupling is confined to the `getRawApp()` escape hatch (metadata HMR, cloud-connection/marketplace routes, static/SPA + CORS + Server-Timing), whose consumers feature-detect and degrade. Follow-up for D11: codify the two soft extensions consumers already rely on (`res.write`/`res.end` for SSE, `getPort()`) and 404/405 semantics into the `IHttpServer` contract.
209+
11. **D12 stub marker****Resolved (#2462): standard `__serviceInfo` self-descriptor** (`ServiceSelfInfoSchema` in `spec/api/discovery.zod.ts`, read via `readServiceSelfInfo()`), with plugin-dev's legacy `_dev: true` normalized to `{ status: 'stub', handlerReady: false }`. Both discovery builders honor it; the analytics fallback self-identifies as `degraded`.
Lines changed: 202 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,202 @@
1+
Apache License
2+
Version 2.0, January 2004
3+
http://www.apache.org/licenses/
4+
5+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
6+
7+
1. Definitions.
8+
9+
"License" shall mean the terms and conditions for use, reproduction,
10+
and distribution as defined by Sections 1 through 9 of this document.
11+
12+
"Licensor" shall mean the copyright owner or entity authorized by
13+
the copyright owner that is granting the License.
14+
15+
"Legal Entity" shall mean the union of the acting entity and all
16+
other entities that control, are controlled by, or are under common
17+
control with that entity. For the purposes of this definition,
18+
"control" means (i) the power, direct or indirect, to cause the
19+
direction or management of such entity, whether by contract or
20+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
21+
outstanding shares, or (iii) beneficial ownership of such entity.
22+
23+
"You" (or "Your") shall mean an individual or Legal Entity
24+
exercising permissions granted by this License.
25+
26+
"Source" form shall mean the preferred form for making modifications,
27+
including but not limited to software source code, documentation
28+
source, and configuration files.
29+
30+
"Object" form shall mean any form resulting from mechanical
31+
transformation or translation of a Source form, including but
32+
not limited to compiled object code, generated documentation,
33+
and conversions to other media types.
34+
35+
"Work" shall mean the work of authorship, whether in Source or
36+
Object form, made available under the License, as indicated by a
37+
copyright notice that is included in or attached to the work
38+
(an example is provided in the Appendix below).
39+
40+
"Derivative Works" shall mean any work, whether in Source or Object
41+
form, that is based on (or derived from) the Work and for which the
42+
editorial revisions, annotations, elaborations, or other modifications
43+
represent, as a whole, an original work of authorship. For the purposes
44+
of this License, Derivative Works shall not include works that remain
45+
separable from, or merely link (or bind by name) to the interfaces of,
46+
the Work and Derivative Works thereof.
47+
48+
"Contribution" shall mean any work of authorship, including
49+
the original version of the Work and any modifications or additions
50+
to that Work or Derivative Works thereof, that is intentionally
51+
submitted to Licensor for inclusion in the Work by the copyright owner
52+
or by an individual or Legal Entity authorized to submit on behalf of
53+
the copyright owner. For the purposes of this definition, "submitted"
54+
means any form of electronic, verbal, or written communication sent
55+
to the Licensor or its representatives, including but not limited to
56+
communication on electronic mailing lists, source code control systems,
57+
and issue tracking systems that are managed by, or on behalf of, the
58+
Licensor for the purpose of discussing and improving the Work, but
59+
excluding communication that is conspicuously marked or otherwise
60+
designated in writing by the copyright owner as "Not a Contribution."
61+
62+
"Contributor" shall mean Licensor and any individual or Legal Entity
63+
on behalf of whom a Contribution has been received by Licensor and
64+
subsequently incorporated within the Work.
65+
66+
2. Grant of Copyright License. Subject to the terms and conditions of
67+
this License, each Contributor hereby grants to You a perpetual,
68+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
69+
copyright license to reproduce, prepare Derivative Works of,
70+
publicly display, publicly perform, sublicense, and distribute the
71+
Work and such Derivative Works in Source or Object form.
72+
73+
3. Grant of Patent License. Subject to the terms and conditions of
74+
this License, each Contributor hereby grants to You a perpetual,
75+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
76+
(except as stated in this section) patent license to make, have made,
77+
use, offer to sell, sell, import, and otherwise transfer the Work,
78+
where such license applies only to those patent claims licensable
79+
by such Contributor that are necessarily infringed by their
80+
Contribution(s) alone or by combination of their Contribution(s)
81+
with the Work to which such Contribution(s) was submitted. If You
82+
institute patent litigation against any entity (including a
83+
cross-claim or counterclaim in a lawsuit) alleging that the Work
84+
or a Contribution incorporated within the Work constitutes direct
85+
or contributory patent infringement, then any patent licenses
86+
granted to You under this License for that Work shall terminate
87+
as of the date such litigation is filed.
88+
89+
4. Redistribution. You may reproduce and distribute copies of the
90+
Work or Derivative Works thereof in any medium, with or without
91+
modifications, and in Source or Object form, provided that You
92+
meet the following conditions:
93+
94+
(a) You must give any other recipients of the Work or
95+
Derivative Works a copy of this License; and
96+
97+
(b) You must cause any modified files to carry prominent notices
98+
stating that You changed the files; and
99+
100+
(c) You must retain, in the Source form of any Derivative Works
101+
that You distribute, all copyright, patent, trademark, and
102+
attribution notices from the Source form of the Work,
103+
excluding those notices that do not pertain to any part of
104+
the Derivative Works; and
105+
106+
(d) If the Work includes a "NOTICE" text file as part of its
107+
distribution, then any Derivative Works that You distribute
108+
must include a readable copy of the attribution notices
109+
contained within such NOTICE file, excluding those notices
110+
that do not pertain to any part of the Derivative Works,
111+
in at least one of the following places: within a NOTICE
112+
text file distributed as part of the Derivative Works; within
113+
the Source form or documentation, if provided along with
114+
the Derivative Works; or, within a display generated by the
115+
Derivative Works, if and wherever such third-party notices
116+
normally appear. The contents of the NOTICE file are for
117+
informational purposes only and do not modify the License.
118+
You may add Your own attribution notices within Derivative
119+
Works that You distribute, alongside or as an addendum to
120+
the NOTICE text from the Work, provided that such additional
121+
attribution notices cannot be construed as modifying the
122+
License.
123+
124+
You may add Your own copyright statement to Your modifications and
125+
may provide additional or different license terms and conditions
126+
for use, reproduction, or distribution of Your modifications, or
127+
for any such Derivative Works as a whole, provided Your use,
128+
reproduction, and distribution of the Work otherwise complies with
129+
the conditions stated in this License.
130+
131+
5. Submission of Contributions. Unless You explicitly state otherwise,
132+
any Contribution intentionally submitted for inclusion in the Work
133+
by You to the Licensor shall be under the terms and conditions of
134+
this License, without any additional terms or conditions.
135+
Notwithstanding the above, nothing herein shall supersede or modify
136+
the terms of any separate license agreement you may have executed
137+
with Licensor regarding such Contributions.
138+
139+
6. Trademarks. This License does not grant permission to use the trade
140+
names, trademarks, service marks, or product names of the Licensor,
141+
except as required for reasonable and customary use in describing the
142+
origin of the Work and reproducing the content of the NOTICE file.
143+
144+
7. Disclaimer of Warranty. Unless required by applicable law or
145+
agreed to in writing, Licensor provides the Work (and each
146+
Contributor provides its Contributions) on an "AS IS" BASIS,
147+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
148+
implied, including, without limitation, any warranties or conditions
149+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
150+
PARTICULAR PURPOSE. You are solely responsible for determining the
151+
appropriateness of using or redistributing the Work and assume any
152+
risks associated with Your exercise of permissions under this License.
153+
154+
8. Limitation of Liability. In no event and under no legal theory,
155+
whether in tort (including negligence), contract, or otherwise,
156+
unless required by applicable law (such as deliberate and grossly
157+
negligent acts) or agreed to in writing, shall any Contributor be
158+
liable to You for damages, including any direct, indirect, special,
159+
incidental, or consequential damages of any character arising as a
160+
result of this License or out of the use or inability to use the
161+
Work (including but not limited to damages for loss of goodwill,
162+
work stoppage, computer failure or malfunction, or any and all
163+
other commercial damages or losses), even if such Contributor
164+
has been advised of the possibility of such damages.
165+
166+
9. Accepting Warranty or Additional Liability. While redistributing
167+
the Work or Derivative Works thereof, You may choose to offer,
168+
and charge a fee for, acceptance of support, warranty, indemnity,
169+
or other liability obligations and/or rights consistent with this
170+
License. However, in accepting such obligations, You may act only
171+
on Your own behalf and on Your sole responsibility, not on behalf
172+
of any other Contributor, and only if You agree to indemnify,
173+
defend, and hold each Contributor harmless for any liability
174+
incurred by, or claims asserted against, such Contributor by reason
175+
of your accepting any such warranty or additional liability.
176+
177+
END OF TERMS AND CONDITIONS
178+
179+
APPENDIX: How to apply the Apache License to your work.
180+
181+
To apply the Apache License to your work, attach the following
182+
boilerplate notice, with the fields enclosed by brackets "[]"
183+
replaced with your own identifying information. (Don't include
184+
the brackets!) The text should be enclosed in the appropriate
185+
comment syntax for the file format. We also recommend that a
186+
file or class name and description of purpose be included on the
187+
same "printed page" as the copyright notice for easier
188+
identification within third-party archives.
189+
190+
Copyright 2026 ObjectStack
191+
192+
Licensed under the Apache License, Version 2.0 (the "License");
193+
you may not use this file except in compliance with the License.
194+
You may obtain a copy of the License at
195+
196+
http://www.apache.org/licenses/LICENSE-2.0
197+
198+
Unless required by applicable law or agreed to in writing, software
199+
distributed under the License is distributed on an "AS IS" BASIS,
200+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
201+
See the License for the specific language governing permissions and
202+
limitations under the License.
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
# @objectstack/plugin-node-server
2+
3+
A **thin, zero-dependency `node:http` adapter** implementing the ObjectStack
4+
transport port (`IHttpServer` from `@objectstack/spec/contracts`).
5+
6+
## Why this exists
7+
8+
The transport layer was designed ports-and-adapters style (ADR-0076 D11), but
9+
only the Hono adapter ever existed — so "the port is framework-agnostic" was
10+
an unproven claim (ADR-0076 OQ#10, issue #2462). This package is the proof:
11+
12+
- `NodeHttpServer` implements the `IHttpServer` contract (plus the two
13+
documented soft extensions consumers feature-detect: SSE streaming via
14+
`res.write`/`res.end`, and `getPort()`) on raw `node:http`, with **no**
15+
framework and **no** third-party dependencies.
16+
- `src/conformance.integration.test.ts` boots the framework's real route
17+
consumers — the dispatcher bridge (`createDispatcherPlugin`) and the REST
18+
route generator (`createRestApiPlugin` + ObjectQL) — on **both** adapters
19+
and asserts identical observable behavior over real sockets, including a
20+
full `/data` CRUD roundtrip, `:param` routing, 404/405 semantics, and
21+
discovery.
22+
23+
If a Hono-ism ever leaks into a route consumer, the node half of that suite
24+
is what breaks.
25+
26+
## What it deliberately does NOT implement
27+
28+
Each of these is a known escape hatch outside the port; consumers
29+
feature-detect and degrade gracefully when they are absent:
30+
31+
- `getRawApp()` — Hono-specific. Metadata HMR routes, cloud-connection /
32+
marketplace routes, and the hono-plugin's static/SPA + CORS + Server-Timing
33+
layers use it and will log-and-skip on this adapter.
34+
- `mount()` — Hono sub-app composition.
35+
- Multipart form parsing — binary/multipart bodies stay raw and are reachable
36+
via the lazy `req.rawBody()` accessor.
37+
38+
Production deployments should keep using `@objectstack/plugin-hono-server`.
39+
This adapter targets the conformance suite and minimal embedding scenarios.
40+
41+
## Usage
42+
43+
```ts
44+
import { LiteKernel } from '@objectstack/core';
45+
import { NodeServerPlugin } from '@objectstack/plugin-node-server';
46+
import { createDispatcherPlugin, createRestApiPlugin } from '@objectstack/runtime';
47+
48+
const kernel = new LiteKernel();
49+
kernel.use(new NodeServerPlugin({ port: 3000 }));
50+
kernel.use(createRestApiPlugin());
51+
kernel.use(createDispatcherPlugin({ prefix: '/api/v1' }));
52+
await kernel.bootstrap();
53+
```
Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
{
2+
"name": "@objectstack/plugin-node-server",
3+
"version": "15.0.0",
4+
"license": "Apache-2.0",
5+
"description": "Thin node:http server adapter for ObjectStack Runtime — the second IHttpServer implementation, proving the transport port is framework-agnostic (ADR-0076 D11 / OQ#10)",
6+
"main": "dist/index.js",
7+
"types": "dist/index.d.ts",
8+
"scripts": {
9+
"build": "tsup --config ../../../tsup.config.ts",
10+
"test": "vitest run"
11+
},
12+
"dependencies": {
13+
"@objectstack/core": "workspace:*"
14+
},
15+
"devDependencies": {
16+
"@objectstack/driver-memory": "workspace:*",
17+
"@objectstack/objectql": "workspace:*",
18+
"@objectstack/plugin-hono-server": "workspace:*",
19+
"@objectstack/runtime": "workspace:*",
20+
"@types/node": "^26.1.1",
21+
"typescript": "^6.0.3",
22+
"vitest": "^4.1.10"
23+
},
24+
"keywords": [
25+
"objectstack",
26+
"plugin",
27+
"node",
28+
"http-server",
29+
"adapter"
30+
],
31+
"author": "ObjectStack",
32+
"repository": {
33+
"type": "git",
34+
"url": "https://github.com/objectstack-ai/framework.git",
35+
"directory": "packages/plugins/plugin-node-server"
36+
},
37+
"homepage": "https://objectstack.ai/docs",
38+
"bugs": "https://github.com/objectstack-ai/framework/issues",
39+
"publishConfig": {
40+
"access": "public"
41+
},
42+
"files": [
43+
"dist",
44+
"README.md"
45+
],
46+
"engines": {
47+
"node": ">=18.0.0"
48+
}
49+
}

0 commit comments

Comments
 (0)