Skip to content

Commit dd66bb6

Browse files
os-zhuangclaude
andauthored
fix(deps): pin esbuild ≥0.28.1 via pnpm-workspace overrides (GHSA-gv7w-rqvm-qjhr) (#1910)
pnpm v10 reads `overrides` from `pnpm-workspace.yaml`, NOT package.json's `pnpm` field (hence the recurring "pnpm field ignored" warning). The repo's minimatch /tar pins lived in package.json and were therefore silently dead, and nothing pinned esbuild at all — so `tsup`/`tsx`/`vite` resolved esbuild 0.27.7 and 0.28.0 (both < 0.28.1), tripping the high-severity advisory GHSA-gv7w-rqvm-qjhr that fails `pnpm audit --audit-level=high` (the "Validate Package Dependencies" CI job) on every dependency-touching PR. Fix: add a real `overrides:` block to pnpm-workspace.yaml — `esbuild: '>=0.28.1'` plus the migrated minimatch/tar pins — and drop the dead `pnpm.overrides` from package.json. esbuild now resolves to a single 0.28.1 across the tree; high advisories drop from 2 to 0. tsup build + vitest verified working on 0.28.1. Test-only tooling/lockfile change; empty changeset. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 15f35bb commit dd66bb6

4 files changed

Lines changed: 29 additions & 606 deletions

File tree

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
---
3+
4+
fix(deps): pin esbuild ≥0.28.1 and migrate orphaned overrides to pnpm-workspace.yaml
5+
6+
pnpm v10 reads `overrides` from `pnpm-workspace.yaml`, not package.json's `pnpm`
7+
field — so the existing minimatch/tar pins were silently ignored and nothing
8+
pinned esbuild. `tsup`/`tsx`/`vite` pulled esbuild 0.27.7 / 0.28.0 (< 0.28.1),
9+
tripping GHSA-gv7w-rqvm-qjhr (high) in `pnpm audit`. Moved all overrides to
10+
`pnpm-workspace.yaml` and added `esbuild: '>=0.28.1'`. No published-package code
11+
change (build/test tooling + lockfile only); empty changeset.

package.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,6 @@
4747
},
4848
"packageManager": "pnpm@10.31.0+sha512.e3927388bfaa8078ceb79b748ffc1e8274e84d75163e67bc22e06c0d3aed43dd153151cbf11d7f8301ff4acb98c68bdc5cadf6989532801ffafe3b3e4a63c268",
4949
"pnpm": {
50-
"overrides": {
51-
"minimatch@<10.2.3": "10.2.3",
52-
"tar@>=2.0.0 <7.5.11": "^7.5.11"
53-
},
5450
"ignoredBuiltDependencies": [
5551
"@nestjs/core",
5652
"@prisma/engines",

0 commit comments

Comments
 (0)