Skip to content

Commit e27120f

Browse files
os-zhuangclaude
andcommitted
test(cli): drop lint assertions for the pruned webhook authentication/retryPolicy props
The liveness compile lint no longer warns on authentication — the prop (and its ledger entry) were removed outright, so the experimental-marker test case is obsolete; the showcase-shaped fixture loses its dead retryPolicy key. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent c0254bc commit e27120f

1 file changed

Lines changed: 5 additions & 11 deletions

File tree

packages/cli/src/utils/lint-liveness-properties.test.ts

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -177,17 +177,18 @@ describe('lintLivenessProperties', () => {
177177
});
178178

179179
it('emits exactly one warning for a fully-authored (showcase-shaped) webhook', () => {
180-
// object/triggers/method/retryPolicy/isActive/description are all dead too,
181-
// but only `url` carries authorWarn — so the whole no-op artifact yields ONE
182-
// finding, not one-per-prop. (isActive is default(true), deliberately unmarked.)
180+
// object/triggers/method/isActive/description are dead too, but only `url`
181+
// carries authorWarn — so the whole no-op artifact yields ONE finding, not
182+
// one-per-prop. (isActive is default(true), deliberately unmarked.
183+
// #3494 pruned the aspirational body/payloadFields/includeSession/
184+
// authentication/retryPolicy/tags props outright.)
183185
const findings = lintLivenessProperties({
184186
webhooks: [{
185187
name: 'showcase_task_changed',
186188
object: 'showcase_task',
187189
triggers: ['create', 'update', 'delete'],
188190
url: 'https://hooks.example/showcase/task',
189191
method: 'POST',
190-
retryPolicy: { maxRetries: 3, backoffStrategy: 'exponential' },
191192
isActive: true,
192193
description: 'Sends task lifecycle events to an external system.',
193194
}],
@@ -196,13 +197,6 @@ describe('lintLivenessProperties', () => {
196197
expect(findings[0].message).toContain('`url`');
197198
});
198199

199-
it('also warns on authentication (experimental — HMAC-secret-only)', () => {
200-
const findings = lintLivenessProperties({
201-
webhooks: [{ name: 'w1', url: 'https://hooks.example/x', authentication: { type: 'bearer' } }],
202-
});
203-
expect(paths(findings).some((m) => m.includes('`authentication`'))).toBe(true);
204-
});
205-
206200
it('does NOT warn on isActive (default(true) boolean, deliberately unmarked)', () => {
207201
const findings = lintLivenessProperties({
208202
webhooks: [{ name: 'w1', url: 'https://hooks.example/x', isActive: true }],

0 commit comments

Comments
 (0)