Commit e43eb0c
fix(showcase): drop dead props f_rating.maxRating / f_vector.vectorConfig (#1973)
The spec-liveness author-warning lint flagged two dead-property usages in
the showcase's field-zoo object that do nothing at runtime:
- f_rating authored `maxRating` (via Field.rating), but RatingField reads
the flat `max` prop. Author `{ type: 'rating', max: 5 }` directly.
- f_vector authored the nested `vectorConfig` block (via Field.vector), but
VectorField reads the flat `dimensions` sibling and there is no
vector-index DDL consuming vectorConfig. Author `{ type: 'vector',
dimensions: 1536 }` directly.
Switched both from the builder helpers to raw literals (matching the style
of other raw-literal fields in this file) so the showcase authors zero dead
props. `objectstack compile` is clean: exit 0, no liveness-dead-property
warnings, no new errors.
Note: the Field.rating/Field.vector builders themselves still emit the dead
props (field.zod.ts) — a separate follow-up.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 796f0d6 commit e43eb0c
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | | - | |
| 124 | + | |
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
0 commit comments