Skip to content

Commit f4b102d

Browse files
xuyushun441-syshotlongclaude
authored
ci(showcase): build dependency closure before the smoke (#2115)
* ci(showcase): build the showcase dependency closure before the smoke The smoke's webServer (`os serve --dev`) loads the showcase config + its workspace runtime deps (connector-rest, …) from their built dist/. The first run failed with "Cannot find module @objectstack/connector-rest/dist/index.mjs" because only the CLI was built. Build the full dependency closure (`--filter=@objectstack/example-showcase^...`) and bump the timeout to 30m. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * ci(showcase): vendor the Console SPA before the smoke serve --dev serves the console at /_console from packages/console/dist, which is gitignored and produced by scripts/build-console.sh (clones objectui@ .objectui-sha, builds @object-ui/console). Without it the second shakedown run warned "Console dist not found" and all 29 surfaces timed out waiting for the app shell. Add the vendoring step and raise the timeout to 45m for the extra clone+build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Jack Zhuang <zhuangjianguo@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 12dc874 commit f4b102d

1 file changed

Lines changed: 12 additions & 3 deletions

File tree

.github/workflows/showcase-smoke.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
smoke:
1717
name: Showcase nav-surface smoke
1818
runs-on: ubuntu-latest
19-
timeout-minutes: 25
19+
timeout-minutes: 45
2020
steps:
2121
- uses: actions/checkout@v4
2222
- uses: pnpm/action-setup@v4
@@ -25,8 +25,17 @@ jobs:
2525
node-version: 22
2626
cache: pnpm
2727
- run: pnpm install --frozen-lockfile
28-
# The smoke's webServer runs the CLI (`os serve --dev`); build it first.
29-
- run: pnpm turbo run build --filter=@objectstack/cli
28+
# The smoke's webServer runs `os serve --dev`, which loads the showcase
29+
# config + its workspace runtime deps (CLI, connector-rest, …) from their
30+
# built `dist/`. Build the whole dependency closure (excluding the
31+
# showcase's own app build, which serve --dev doesn't need).
32+
- run: pnpm turbo run build --filter=@objectstack/example-showcase^...
33+
# The console SPA served at /_console is vendored by build-console.sh
34+
# (shallow-clones objectui@.objectui-sha, builds @object-ui/console, copies
35+
# dist → packages/console/dist). Without it serve --dev warns "Console dist
36+
# not found" and the app shell never renders.
37+
- name: Vendor the pinned Console SPA
38+
run: bash scripts/build-console.sh
3039
- name: Install Playwright Chromium
3140
working-directory: examples/app-showcase
3241
run: pnpm exec playwright install --with-deps chromium

0 commit comments

Comments
 (0)