fix: address code review feedback

- Simplify ExtractOptionValues to use only ReadonlyArray (supertype of Array)
- Rename ambiguous 'obj' parameter to 'value' in checkPlaceholderResidue
- Use Omit<ServiceObject, 'fields'> & Pick<T, 'fields'> to avoid type conflicts

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

packages/spec/src/data/object.zod.ts

@@ -378,12 +378,12 @@ export const ObjectSchema = Object.assign(ObjectSchemaBase, {
    * });
    * ```
    */
-  create: <const T extends z.input<typeof ObjectSchemaBase>>(config: T): ServiceObject & Pick<T, 'fields'> => {
+  create: <const T extends z.input<typeof ObjectSchemaBase>>(config: T): Omit<ServiceObject, 'fields'> & Pick<T, 'fields'> => {
     const withDefaults = {
       ...config,
       label: config.label ?? snakeCaseToLabel(config.name),
     };
-    return ObjectSchemaBase.parse(withDefaults) as ServiceObject & Pick<T, 'fields'>;
+    return ObjectSchemaBase.parse(withDefaults) as Omit<ServiceObject, 'fields'> & Pick<T, 'fields'>;
   },
 });
 

packages/spec/src/system/translation-typegen.ts

@@ -40,9 +40,7 @@
 type ExtractOptionValues<F> =
   F extends { options: ReadonlyArray<infer O> }
     ? O extends { value: infer V extends string } ? V : never
-    : F extends { options: Array<infer O> }
-      ? O extends { value: infer V extends string } ? V : never
-      : never;
+    : never;
 
 // ────────────────────────────────────────────────────────────────────────────
 // Per-Field Translation Shape

packages/spec/src/system/translation-validator.ts

@@ -104,19 +104,19 @@ export function validateTranslationCompleteness(
  * Recursively checks for `__TRANSLATE__` placeholder residue in values.
  */
 function checkPlaceholderResidue(
-  obj: unknown,
+  value: unknown,
   path: string,
   errors: string[],
 ): void {
-  if (typeof obj === 'string') {
-    if (obj.includes(TRANSLATE_PLACEHOLDER)) {
+  if (typeof value === 'string') {
+    if (value.includes(TRANSLATE_PLACEHOLDER)) {
       errors.push(`placeholder residue: ${path}`);
     }
     return;
   }
-  if (obj && typeof obj === 'object') {
-    for (const [key, value] of Object.entries(obj)) {
-      checkPlaceholderResidue(value, path ? `${path}.${key}` : key, errors);
+  if (value && typeof value === 'object') {
+    for (const [key, child] of Object.entries(value)) {
+      checkPlaceholderResidue(child, path ? `${path}.${key}` : key, errors);
     }
   }
 }