fix(cloud-connection): never present env_local/proj_local as cloud environment ids#1786
Merged
Conversation
…vironment ids The CLI's dev/serve default OS_ENVIRONMENT_ID=env_local names the LOCAL kernel, not a control-plane environment. Presenting it to the cloud 404s the bind and resurrects the phantom-environment confusion that ADR runtime-identity-binding removes. Filter the sentinels in resolveEnvironmentId — such runtimes are simply unbound until the device-code registration completes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during the runtime-identity-binding E2E:
objectstack devexportsOS_ENVIRONMENT_ID=env_local(a local-kernel identifier), which the cloud-connection plugin treated as a cloud environment id — the bind then 404s against a non-existent env, resurrecting exactly the phantom-environment confusion the ADR removes. Filter the two CLI sentinels inresolveEnvironmentId; such runtimes read as cleanly unbound and bind environment-less.+1 test; 41/41 green.
🤖 Generated with Claude Code