docs(adr): revise ADR-0048 — package-scoped identity over per-item collision detection#1809
Merged
Merged
Conversation
…llision detection Re-examine the cross-package metadata collision problem through the app-marketplace install lens. Per-item collision detection (shipped) makes two independent vendors that both ship a bare-named `page/home` unable to coexist — wrong for a marketplace. Revised direction: - package id (reverse-domain) is the global identity + routing/container key (vendor baked in → two vendors' "crm" never collide; URL-safe) - namespace stays the object prefix, enforced unique per-install at install time (refuse-on-conflict) — making explicit the constraint the table layer already enforces implicitly - resolution is container-scoped (prefer-local, qualify-to-cross), so a cross-package clash is structurally impossible rather than detected - the shipped runtime guard is retained as a same-package authoring backstop - namespace rename-on-install is an explicit non-goal for v1 Docs-only. The runtime guard + os lint rule remain accurately labelled [done]; the install gate + container-scoped resolution are labelled [proposed]. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
os-zhuang
added a commit
that referenced
this pull request
Jun 20, 2026
feat(plugin-gantt): locate icon + flash highlight + group node type (4-level tree) (#1809) objectui@c125273f78b64713709bf94817e066e87ce399d6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Revises ADR-0048 to re-frame cross-package metadata collisions for the app-marketplace era. Docs-only.
Why
The original ADR chose per-item collision detection at registration time — turn a silent shadow into a loud error. That guard shipped and stays. But for a marketplace it's the wrong terminal design: two independent vendors that both ship a bare-named
page/homewould be unable to coexist (the second install fails). A marketplace whose packages can't be installed together on common names isn't a marketplace.Revised direction
com.acme.crm) is the global identity + routing/container key — vendor baked in, so two vendors' "crm" never collide; URL-safe; already the dependency-resolution identity.CREATE TABLE crm_accountfails loudly).Net: one
O(1)-per-package namespace install gate replaces theO(every page/dashboard/flow)per-item scan; object and UI metadata share one scope model with zero artifact renames.Accuracy
[done]— runtime guard (MetadataCollisionError,collisionPolicy,registry.ts) +naming/namespace-prefixos-lint rule (already shipped) are labelled as such.[proposed]— install-time namespace gate + container-scoped resolution + qualified cross-package references.[deferred]— namespace rename-on-install.No code changes — ADR document only.
🤖 Generated with Claude Code