Skip to content

fix(spec): render action body editor as composite (language + source), not [object Object] #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuyushun441-sys merged 2 commits into from
Jun 15, 2026
Merged

fix(spec): render action body editor as composite (language + source), not [object Object] #1855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
110c699
fix(spec): render action `body` as composite, not a flat code editor
os-zhuang Jun 14, 2026
b9f894c
chore(changeset): action body composite fix
os-zhuang Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/studio-action-body-composite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@objectstack/spec": patch
---

fix(spec): render action `body` as a composite editor (language + source) instead of a flat code field

An action's `body` is a discriminated union (`HookBodySchema`), the same shape hooks use, but `action.form.ts` mapped the whole field to `{ widget: 'code' }`, so the Studio inspector fed the union object to a single JS editor and rendered `[object Object]`. The layout now mirrors the working `hook.form.ts`: a composite with a `language` select, a `source` code editor, and the L2-only capability/timeout knobs.
21 changes: 20 additions & 1 deletion packages/spec/src/ui/action.form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,26 @@ export const actionForm = defineForm({
fields: [
{ field: 'target', visibleOn: "data.type != 'script'", helpText: 'URL, flow name, or API endpoint to call' },
{ field: 'method', visibleOn: "data.type == 'api'", helpText: 'HTTP method (GET, POST, PUT, DELETE)' },
{ field: 'body', widget: 'code', visibleOn: "data.type == 'script'", helpText: 'JavaScript code to execute' },
{
field: 'body',
type: 'composite',
visibleOn: "data.type == 'script'",
helpText: 'Either an L1 expression or an L2 sandboxed JS body',
// Mirrors hook.form.ts: `body` is a discriminated union
// (HookBodySchema) on `language`, not a bare string. A flat
// `widget: 'code'` fed the whole object to the editor and rendered
// "[object Object]". Render the union as language + source (+ the
// L2-only capability/timeout knobs).
fields: [
{ field: 'language', type: 'select', required: true, helpText: 'expression = pure formula; js = sandboxed JavaScript', options: [
{ label: 'Expression (L1)', value: 'expression' },
{ label: 'JavaScript (L2 sandboxed)', value: 'js' },
] },
{ field: 'source', type: 'code', language: 'javascript', required: true, helpText: 'Function body source — no top-level imports' },
{ field: 'capabilities', type: 'tags', helpText: 'Allowed ctx APIs (api.read, api.write, crypto.uuid, log, …)' },
{ field: 'timeoutMs', type: 'number', helpText: 'Per-invocation timeout (ms)' },
],
},
{ field: 'params', type: 'repeater', helpText: 'User input parameters (show form before executing)' },
{ field: 'confirmText', helpText: 'Confirmation message (e.g., "Are you sure?")' },
{ field: 'successMessage', helpText: 'Success message after completion' },
Expand Down