refactor(audit): move sys_attachment ownership audit → storage (ADR-0052 P0b)#1954
Merged
Merged
Conversation
…052 P0b) A file↔record link belongs with the storage domain, not the compliance ledger. `plugin-audit` stops registering `sys_attachment`; `service-storage` now contributes it (definition stays in platform-objects). Both plugins are always-on, so the object stays available — no behavior change. Audit sheds one of its dumping-ground objects, moving toward a pure append-only ledger. `sys_notification` is intentionally NOT moved: it is mid-migration to an event model (migrate-sys-notification-to-event.ts, ADR-0030) and touching it now would collide with that in-flight work. - plugin-audit: drop SysAttachment from registered objects + import - service-storage: depend on platform-objects, import + register SysAttachment - ADR-0052 §6 P0b updated (sys_attachment done; sys_notification deferred) Verified in the showcase: sys_attachment still resolves (meta + data 200), no double-registration; plugin-audit 18/18 + service-storage 48/48 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 9 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ADR-0052 P0b (partial) — move
sys_attachmentownership out of the audit/compliance ledger.plugin-auditwas a dumping ground registering 5 objects across 5 domains. This sheds one: a file↔record link (sys_attachment) belongs with the storage domain.plugin-auditstops registering it;service-storagenow contributes it (the definition stays inplatform-objects). Both plugins are always-on, so the object stays available — no behavior change.sys_notificationis intentionally not moved: it is mid-migration to an event model (migrate-sys-notification-to-event.ts, ADR-0030); moving it now would collide with that in-flight work. Deferred and documented.Changes
plugin-audit: dropSysAttachmentfrom registered objects + import.service-storage: depend on@objectstack/platform-objects, import + registerSysAttachment(no dependency cycle — platform-objects doesn't depend on storage).Verification (showcase, browser)
meta/object/sys_attachment→ 200 (still registered, now via storage);data/sys_attachment→ 200; no double-registration / collision at boot.plugin-audit18/18 +service-storage48/48 tests pass; both build clean.Builds on
#1948 (trackHistory §5b.1) + #1952 (milestones §5b.2). Remaining:
sys_notification(after its event migration), P1 split-brain convergence, P2 event bus, objectui feed surfacing.🤖 Generated with Claude Code