fix(i18n): add view form end_user_controls translations#2016
Merged
Conversation
The view form's `end_user_controls` section (ADR-0047) and its six fields (userFilters, tabs, appearance, userActions, addRecord, showRecordCount) were missing from the generated metadata-forms translation bundles, so they always fell back to English labels/helpText in the view editor even under non-English locales. Sync all four locale bundles (en, zh-CN, ja-JP, es-ES) with packages/spec/src/ui/view.form.ts. The view form's section/field key set now matches the spec exactly.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 3 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the view editor (`编辑视图`), the End-user controls section (ADR-0047, Airtable Interface parity) and its six fields rendered in English even under non-English locales (zh-CN / ja-JP / es-ES).
Root cause: the generated metadata-forms translation bundles were stale relative to `packages/spec/src/ui/view.form.ts`. The `end_user_controls` section and its fields (`userFilters`, `tabs`, `appearance`, `userActions`, `addRecord`, `showRecordCount`) had no entries under `metadataForms.view`, so the server-side localization (`rest-server.ts` → `translateMetadataDocument`) had nothing to apply and the form fell back to the raw English spec strings.
Fix
Add the missing `end_user_controls` section (label + description) and its six fields (label + helpText) to all four generated locale bundles:
The `view` form's section/field key set now matches the spec exactly (verified by diffing section/field names in `view.form.ts` against the generated keys). These generated files are hand-editable per `metadata-translations/index.ts`.
Verification