feat(spec): interface base filterBy uses the unified filter-builder widget#2056
Merged
Conversation
…idget The page form rendered `interfaceConfig.filterBy` (the always-on base filter) as a generic `type:'repeater'`, a different and clunkier editor than the polished FilterBuilder the list toolbar uses. Switch it to `widget:'filter-builder'` with `dependsOn:'source'` so the Studio renders the same popout visual builder for the base filter as for the per-tab presets — one consistent filter UX everywhere. The widget is implemented in objectui (SchemaForm widget registry); stored format is unchanged (ViewFilterRule[]). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 89 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The page form rendered
interfaceConfig.filterBy(the always-on base filter) as a generictype:'repeater'— a different, clunkier editor than the polished FilterBuilder the list toolbar uses.What
Switch the base
filterByfield towidget:'filter-builder'withdependsOn:'source', so the Studio renders the same popout visual builder for the base filter as for the per-tab presets — one consistent filter UX everywhere.The widget is implemented in objectui (SchemaForm widget registry, companion PR objectui#1813). Stored format is unchanged (
ViewFilterRule[]).Verification
Verified in the studio (
:5181) againstshowcase_task_triageafterpnpm --filter @objectstack/spec build+ backend restart: the base Filter By now shows the "+ Add filter…" popout builder, conditions apply live to the preview, and round-trip to the runtime works.🤖 Generated with Claude Code