fix(app-showcase): surface Task Detail quick actions in the record_section bar#2082
Merged
Merged
Conversation
…ction bar The Task Detail page's `record:quick_actions` bar (location: 'record_section') names `showcase_mark_done` + `showcase_log_time`, but neither action declared the `record_section` location, so the engine location-filtered them out and the drawer showed the dev placeholder "record:quick_actions — no actions configured". Add `record_section` to both actions' locations, mirroring the platform's own sys-user pages, so the Mark Done / Log Time buttons render. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
xuyushun441-sys
added
the
skip-changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While QA-ing the showcase workspace, the Task Detail drawer leaked a dev placeholder into the business UI:
Root cause
The Task Detail page's
record:quick_actionsbar is configured withlocation: 'record_section'andactionNames: ['showcase_mark_done', 'showcase_log_time']. The renderer resolves those named actions, then location-filters them viagetActionsForLocation('record_section')— but neither action declaredrecord_sectionin itslocations(mark_done waslist_item/record_header; log_time wasrecord_header/record_related), so both were filtered out.This is the platform's intended contract: the platform's own
sys-user.page.tsuses the identical pattern, and every action it names in arecord_sectionbar (change_my_password,delete_my_account, …) declaresrecord_sectionin its object definition.Fix
Add
record_sectionto thelocationsofshowcase_mark_doneandshowcase_log_time(metadata only), matching the platform convention.Testing
Verified in the browser (showcase backend rebuilt from this branch): the Task Detail drawer now renders the Mark Done and Log Time buttons instead of the placeholder.
🤖 Generated with Claude Code