Skip to content

chore(spec): drop the dead agent memory.shortTerm config (ADR-0013 D3, cloud#339) #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuyushun441-sys merged 1 commit into from
Jun 21, 2026
Merged

chore(spec): drop the dead agent memory.shortTerm config (ADR-0013 D3, cloud#339) #2094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/services/service-ai/src/agents/data-chat-agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,5 @@ Always answer in the same language the user is using. Detailed tool-usage guidan
maxIterations: 10,
allowReplan: true,
},

memory: {
shortTerm: {
maxMessages: 20,
maxTokens: 4096,
},
},
};

5 changes: 0 additions & 5 deletions packages/spec/src/ai/agent.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,10 +589,6 @@ Be precise, data-driven, and clear in your explanations.`,
role: 'Persistent Assistant',
instructions: 'Remember across sessions.',
memory: {
shortTerm: {
maxMessages: 100,
maxTokens: 4096,
},
longTerm: {
enabled: true,
store: 'vector',
Expand All @@ -602,7 +598,6 @@ Be precise, data-driven, and clear in your explanations.`,
},
});

expect(agent.memory?.shortTerm?.maxMessages).toBe(100);
expect(agent.memory?.longTerm?.enabled).toBe(true);
expect(agent.memory?.longTerm?.store).toBe('vector');
expect(agent.memory?.reflectionInterval).toBe(5);
Expand Down
14 changes: 6 additions & 8 deletions packages/spec/src/ai/agent.zod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,12 @@ export const AgentSchema = lazySchema(() => z.object({

/** Memory Management */
memory: z.object({
/** Short-term (working) memory configuration */
shortTerm: z.object({
/** Maximum number of recent messages to retain */
maxMessages: z.number().int().min(1).default(50).describe('Max recent messages in working memory'),

/** Maximum token budget for short-term context */
maxTokens: z.number().int().min(100).optional().describe('Max tokens for short-term context window'),
}).optional().describe('Short-term / working memory'),
// NOTE: `shortTerm` ({maxMessages,maxTokens}) was removed (ADR-0013 D3,
// cloud#339). It declared a working-memory window that NOTHING in the
// runtime consumed — a config that lies. Cross-turn grounding is done by
// tools reading live state, and the context budget is governed elsewhere
// (the per-request token guardrail), not by this field. `longTerm` /
// `reflectionInterval` are kept as forward-looking, off-by-default config.

/** Long-term (persistent) memory configuration */
longTerm: z.object({
Expand Down
Loading