ci(showcase): build dependency closure before the smoke#2115
Merged
Conversation
The smoke's webServer (`os serve --dev`) loads the showcase config + its workspace runtime deps (connector-rest, …) from their built dist/. The first run failed with "Cannot find module @objectstack/connector-rest/dist/index.mjs" because only the CLI was built. Build the full dependency closure (`--filter=@objectstack/example-showcase^...`) and bump the timeout to 30m. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
xuyushun441-sys
added
the
skip-changeset
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
serve --dev serves the console at /_console from packages/console/dist, which is gitignored and produced by scripts/build-console.sh (clones objectui@ .objectui-sha, builds @object-ui/console). Without it the second shakedown run warned "Console dist not found" and all 29 surfaces timed out waiting for the app shell. Add the vendoring step and raise the timeout to 45m for the extra clone+build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
os-zhuang
added a commit
that referenced
this pull request
Jun 30, 2026
Records the model that the spec↔contract↔conformance↔prop-gate work converged on (now implemented + merged across framework #2478/#2480/#2482/#2484/#2485/#2488/ #2489 and objectui #2113/#2115), so future contributors don't re-litigate it: - the spec zod schema is the protocol source of truth; the AI-facing contract is GENERATED from it (zero-drift), never hand-authored; - registry inputs are the designer palette (a curated subset) — spec-only is a soft signal, frontend-only is the actionable one; - React-interaction props (callbacks/controlled/binding escape-hatches) live in a thin overlay, not the spec; declaring a genuine binding there is how a frontend-only prop is closed (baseline now 0 frontend-only); - conformance is a build-time baseline ratchet (build-console.sh, warn-only), not a per-PR gate — the manifest only exists at console-build time; - authoring correctness is a hard gate at os validate (missing-required = error, typo = warning); and the dogfood golden page proves the chain closes. Captures the alternatives rejected (copy props into spec / per-PR hard gate / hand-authored contract / registry-as-source). Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the showcase-smoke workflow (added in #2109): its first
workflow_dispatchshakedown failed becauseos serve --devcouldn't load@objectstack/connector-rest/dist/index.mjs— only the CLI was built, not the showcase's workspace runtime deps.Now builds the full dependency closure (
pnpm turbo run build --filter=@objectstack/example-showcase^..., excluding the showcase's own app build whichserve --devdoesn't need) and bumps the job timeout to 30m.Verifying via a
workflow_dispatchrun on this branch before merge. Still non-blocking (manual + nightly only).🤖 Generated with Claude Code