fix(platform-objects): complete ADR-0057 BU rename — Setup menu + i18n (Departments → Business Units / 业务单元)#2129
Merged
Conversation
…nts → Business Units The sys_department → sys_business_unit rename (ADR-0057 D2) left the Setup menu entry and the non-English object labels on the old term. Rename nav id nav_departments → nav_business_units, label Departments → Business Units, and align the zh / ja / es object + nav labels to 业务单元 / ビジネスユニット / Unidad de negocio (English object label was already "Business Unit"). The deliberately multi-concept descriptions are left unchanged. Verified live in the console: Setup → 人员与组织 → 业务单元 (→ sys_business_unit); the object list page header also renders 业务单元. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…(labels + descriptions + all locales) The earlier nav/label pass was a half-rename: the object DEFINITION (the source of truth) still said "department" in field labels (Parent Department / Department Head / Department ID) and field descriptions, and only the English *generated* labels had been hand-patched ahead of it — so the def was the silently-stale source and every non-English field label/help still read 部门 / 部門 / Departamento. This completes it end-to-end: - sys-business-unit.object.ts / sys-business-unit-member.object.ts: rename field labels + descriptions + comments to "business unit". - en/zh/ja/es .objects.generated.ts: align every field label, help string, and the member object to Business Unit / 业务单元 / ビジネスユニット / Unidad de negocio. Deliberately preserved: the `kind` enum value `department` (a BU can be OF KIND department), the multi-concept descriptions that list kinds, and the unrelated 部署 = "deployment" strings. The internal view id `all_departments` is left (renaming it orphans translation keys; it is not user-facing — label is "All"). Verified: object label + field labels render correctly in the console; a full cross-locale scan of the two object blocks is clean. (Field *help* text can render stale from a prebuilt console bundle — a known dev-bundle cache, not a source gap.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 3 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes the ADR-0057
sys_department→sys_business_unitrename in the Setup app and the object's i18n — the prior rename left the user-facing surface half-renamed.Setup menu
nav_departments/ label "Departments" pointing atsys_business_unit. Renamed tonav_business_units/ "Business Units" and aligned all four locale nav bundles.Object labels & descriptions (the real root)
sys-business-unit.object.ts) still said "department" in field labels (Parent Department,Department Head,Department ID) and descriptions — while the generatedenlabels had been hand-updated ahead of it, making the def a silently-stale source. Fixed at the source.en/zh/ja/es) aligned to 业务单元 / ビジネスユニット / Unidad de negocio across labels, help text, and thesys_business_unit_memberobject.Intentionally preserved (not over-renamed)
kindenum valuedepartment— a business unit can be of kind department.company / division / department / …).部署= "deployment" strings (same characters as Japanese 部署="department" — a blind replace would have corrupted them).Verification
sys_business_unit); the object list/form headers and field labels render the new term.🤖 Generated with Claude Code