docs(adr): ADR-0061 record search architecture + liveness audit#2131
Merged
Conversation
Record search is a declared-but-unenforced surface: `$search` / FullTextSearchSchema is defined and sent by every client (lookup picker, list, command palette) but no engine/driver executes it — a silent no-op (only the public-form picker filters). `$searchFields` is already sent by the client, undocumented and unhonored (drift); three object/view search-metadata shapes have zero data-layer consumers. - docs/audits/2026-06-record-search-liveness.md — evidence base (file:line, LIVE/DEAD/PARTIAL) across spec/objectql/rest/drivers/services + objectui. - docs/adr/0061-record-search-architecture.md — decision: enforce search as one metadata-driven, server-resolved capability; client sends the query, server resolves fields from object metadata; single resolver for all surfaces behind a two-tier executor (driver contains now; FTS/relevance/external later); additive migration. D1–D7 + normative defaults + phasing + conformance proof (ADR-0060) + rejected alternatives (incl. the renderer $or hack). Builds on ADR-0045 (visibility gate), ADR-0049 (enforce-or-remove), ADR-0054 (runtime proof), ADR-0060 (conformance ledger). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the architecture decision for record search, which a grounded liveness sweep showed is a declared-but-unenforced capability (cf. ADR-0049):
$search/FullTextSearchSchemais defined and sent by every client surface (lookup picker, list quick-search, ⌘K), but no engine or driver executes it — a silent no-op. Only the public-form picker filters;$searchFieldsis already sent by the client (undocumented, unhonored → drift); three object/view search-metadata shapes have zero data-layer consumers.This came out of the lookup-picker UX work (#2125 / #2128 and objectui #1860 / #1863): "multi-field lookup search" turned out to be one symptom of a platform-wide gap, which warranted an ADR rather than a renderer patch.
Contents
docs/audits/2026-06-record-search-liveness.md— evidence base: every search surface withfile:lineand LIVE/DEAD/PARTIAL, across spec / objectql / rest / drivers / services and objectui.docs/adr/0061-record-search-architecture.md— the decision: enforce search as one metadata-driven, server-resolved capability. Client sends the query text; the server resolves fields from object metadata; a single resolver feeds all surfaces behind a two-tier executor (drivercontainsnow; native FTS / external engine / relevance later); additive migration.Decisions (D1–D7)
$search; server resolves fields;$searchFieldsbecomes a server-validated override.object.searchableFieldscanonical;searchableboolean gate; view override; auto-default; collapse duplicate metadata.contains+ engine in-memory fallback; Tier 2 trigram/tsvector/external + relevance.searchAll— client fan-out now; unified server endpoint is Tier 2; knowledge/vector stays separate.Plus a normative default-behaviour table, a conformance proof aligned with ADR-0060 (
$searchis "landed" iff a driver executes it and a dogfood proof asserts a multi-field match), and rejected alternatives (incl. the renderer$orhack — kept only as a throwaway P0 stopgap).Status: Proposed — recommended for acceptance; no code changes in this PR. Docs only.