Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .changeset/page-hard-remove-dead-schemas.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
"@objectstack/spec": minor
---

chore(spec): hard-remove the dead `blank`/`record_review` page config (enforce-or-remove)

Completes the enforce-or-remove started in framework#2265. The `blank` and
`record_review` page types were already removed from `PageTypeSchema` (no
renderer), their fields marked `@deprecated`, and objectui dropped all
references (objectui#1949). This deletes the now-unreachable surface:

- `BlankPageLayoutSchema`, `BlankPageLayoutItemSchema`, `RecordReviewConfigSchema`
(and their inferred types `BlankPageLayout`, `BlankPageLayoutItem`,
`RecordReviewConfig`).
- The `blankLayout` and `recordReview` fields on `PageSchema`.
- `page-builder.zod.ts` (the `blank`-type drag-drop canvas config:
`PageBuilderConfigSchema` / `CanvasSnapSettingsSchema` / `CanvasZoomSettingsSchema`
/ `ElementPaletteItemSchema` / `InterfaceBuilderConfigSchema` and their types)
and its `@objectstack/spec/studio` re-exports — nothing consumed them.

The `page` liveness ledger drops to 15 properties (the 2 `dead` entries are gone).
No consumers in framework or objectui (objectui#1949 already merged).
10 changes: 1 addition & 9 deletions packages/spec/liveness/page.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"type": "page",
"_note": "PageSchema (UI). Renderers live in objectui, so consumers are cited as prose in `note` (not `evidence`, which resolves framework file:line). Seeded from the Studio page-design dogfood (framework#2254/#2261/#2265). Containers (variables/regions/interfaceConfig/slots/aria) classified at top level — one drill level, no divergent sub-statuses. `recordReview`/`blankLayout` are `dead`: their page types (record_review/blank) were removed from PageTypeSchema (framework#2265) and objectui dropped all references (objectui#1949); the fields remain @deprecated pending hard-removal.",
"_note": "PageSchema (UI). Renderers live in objectui, so consumers are cited as prose in `note` (not `evidence`, which resolves framework file:line). Seeded from the Studio page-design dogfood (framework#2254/#2261/#2265). Containers (variables/regions/interfaceConfig/slots/aria) classified at top level — one drill level, no divergent sub-statuses. The removed roadmap page types (record_review/blank) and their config fields (recordReview/blankLayout) were hard-removed — no longer authorable.",
"props": {
"name": {
"status": "live",
Expand Down Expand Up @@ -30,14 +30,6 @@
"status": "live",
"note": "record-page binding + interfaceConfig source object — objectui PageView / InterfaceListPage."
},
"recordReview": {
"status": "dead",
"note": "Config for the removed `record_review` page type (no renderer; dropped from PageTypeSchema, framework#2265; objectui refs removed in objectui#1949). Field kept @deprecated — enforce-or-remove: slated for hard-removal."
},
"blankLayout": {
"status": "dead",
"note": "Config for the removed `blank` page type (no renderer; dropped from PageTypeSchema, framework#2265; objectui refs removed in objectui#1949). Field kept @deprecated — enforce-or-remove: slated for hard-removal."
},
"template": {
"status": "live",
"note": "layout template (e.g. header-sidebar-main) selects the region arrangement — objectui components/renderers/layout/page.tsx + containers.tsx."
Expand Down
19 changes: 2 additions & 17 deletions packages/spec/src/studio/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,23 +82,8 @@ export {
defineObjectDesignerConfig,
} from './object-designer.zod';

export {
// Page Builder Schemas
CanvasSnapSettingsSchema,
CanvasZoomSettingsSchema,
ElementPaletteItemSchema,
PageBuilderConfigSchema,
/** @deprecated Use PageBuilderConfigSchema instead */
InterfaceBuilderConfigSchema,

// Page Builder Types
type CanvasSnapSettings,
type CanvasZoomSettings,
type ElementPaletteItem,
type PageBuilderConfig,
/** @deprecated Use PageBuilderConfig instead */
type InterfaceBuilderConfig,
} from './page-builder.zod';
// Page Builder schemas removed — they configured the `blank` page-type drag-drop
// canvas, which has no renderer and was dropped from PageTypeSchema (framework#2265).

export {
// Flow Builder Schemas
Expand Down
118 changes: 0 additions & 118 deletions packages/spec/src/studio/page-builder.test.ts

This file was deleted.

76 changes: 0 additions & 76 deletions packages/spec/src/studio/page-builder.zod.ts

This file was deleted.

Loading
Loading