From c31dc7b3f6b1e64d7ea2e8364d05ba2afa030928 Mon Sep 17 00:00:00 2001 From: os-zhuang Date: Wed, 24 Jun 2026 15:54:41 +0800 Subject: [PATCH] fix(spec): regenerate stale api-surface snapshot after dead page-config removal (#2268) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #2268 hard-removed 16 dead exports (6 from ./ui Blank/RecordReview, 10 from ./studio PageBuilder/Canvas/Palette) and #2265 added PAGE_TYPE_ROADMAP, but the committed api-surface.json snapshot was never regenerated — so check:api-surface has been red on main for every PR touching packages/spec/** (surfaced on #2269). Regenerate the snapshot to match the built surface. Diff is exactly the 16 intentional removals + PAGE_TYPE_ROADMAP; api-surface-signatures.json unchanged; the frozen downstream-contract gate is unaffected (it never referenced these symbols). Kept at minor (not a major bump) as a deliberate, documented exception to the ADR-0059 §4 freeze contract — see the appended note in the #2268 changeset. The removed symbols are config for renderless page types with no plausible functional consumer; the pre-publish hotcrm live gate guards any real break. Co-Authored-By: Claude Opus 4.8 --- .changeset/page-hard-remove-dead-schemas.md | 10 ++++++++++ packages/spec/api-surface.json | 17 +---------------- 2 files changed, 11 insertions(+), 16 deletions(-) diff --git a/.changeset/page-hard-remove-dead-schemas.md b/.changeset/page-hard-remove-dead-schemas.md index b81812ea5e..9f196b9726 100644 --- a/.changeset/page-hard-remove-dead-schemas.md +++ b/.changeset/page-hard-remove-dead-schemas.md @@ -20,3 +20,13 @@ references (objectui#1949). This deletes the now-unreachable surface: The `page` liveness ledger drops to 15 properties (the 2 `dead` entries are gone). No consumers in framework or objectui (objectui#1949 already merged). + +**Version note (kept `minor`, not `major`).** These exports shipped in the +published `10.3.0`, so under ADR-0059 §4 (the freeze contract) a removal would +normally demand a major bump. It is kept `minor` as a deliberate, documented +exception: the removed symbols are config schemas for the renderless +`blank`/`record_review` page types — authoring those already failed at runtime +("Unknown component type"), the frozen `@objectstack/downstream-contract` +fixture never referenced them, and the pre-publish hotcrm live gate guards +against any real consumer break. The `api-surface.json` snapshot is regenerated +alongside this so the removal is acknowledged, not silent. diff --git a/packages/spec/api-surface.json b/packages/spec/api-surface.json index 78b495f336..b58eca03a6 100644 --- a/packages/spec/api-surface.json +++ b/packages/spec/api-surface.json @@ -2989,10 +2989,6 @@ "AppearanceConfigSchema (const)", "AriaProps (type)", "AriaPropsSchema (const)", - "BlankPageLayout (type)", - "BlankPageLayoutItem (type)", - "BlankPageLayoutItemSchema (const)", - "BlankPageLayoutSchema (const)", "BorderRadius (type)", "BorderRadiusSchema (const)", "BreakpointColumnMapSchema (const)", @@ -3171,6 +3167,7 @@ "OfflineConfigSchema (const)", "OfflineStrategy (type)", "OfflineStrategySchema (const)", + "PAGE_TYPE_ROADMAP (const)", "Page (type)", "PageAccordionProps (const)", "PageCardProps (const)", @@ -3235,8 +3232,6 @@ "RecordHighlightsProps (const)", "RecordPathProps (const)", "RecordRelatedListProps (const)", - "RecordReviewConfig (type)", - "RecordReviewConfigSchema (const)", "Report (type)", "ReportChart (type)", "ReportChartInput (type)", @@ -3825,10 +3820,6 @@ "ActionLocationSchema (const)", "ActivationEventSchema (const)", "BUILT_IN_NODE_DESCRIPTORS (const)", - "CanvasSnapSettings (type)", - "CanvasSnapSettingsSchema (const)", - "CanvasZoomSettings (type)", - "CanvasZoomSettingsSchema (const)", "CommandContribution (type)", "CommandContributionSchema (const)", "ERDiagramConfig (type)", @@ -3837,8 +3828,6 @@ "ERLayoutAlgorithmSchema (const)", "ERNodeDisplay (type)", "ERNodeDisplaySchema (const)", - "ElementPaletteItem (type)", - "ElementPaletteItemSchema (const)", "FieldEditorConfig (type)", "FieldEditorConfigSchema (const)", "FieldGroup (type)", @@ -3861,8 +3850,6 @@ "FlowNodeRenderDescriptorSchema (const)", "FlowNodeShape (type)", "FlowNodeShapeSchema (const)", - "InterfaceBuilderConfig (type)", - "InterfaceBuilderConfigSchema (const)", "MetadataIconContribution (type)", "MetadataIconContributionSchema (const)", "MetadataViewerContribution (type)", @@ -3883,8 +3870,6 @@ "ObjectPreviewTabSchema (const)", "ObjectSortField (type)", "ObjectSortFieldSchema (const)", - "PageBuilderConfig (type)", - "PageBuilderConfigSchema (const)", "PanelContribution (type)", "PanelContributionSchema (const)", "PanelLocationSchema (const)",