fix(cli): type approvalFlow test helper's edges param (unblock TS on main)#2283
Merged
Conversation
… on main) `packages/cli/src/utils/lint-flow-patterns.test.ts:190` had an untyped `edges` parameter (TS7006 under the build's noImplicitAny), introduced by #2279. The TypeScript Type Check job builds the whole workspace, so this fails CI for *every* open PR. Add the edge-array type (and an explicit approvalConfig type). Test-only; no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 15 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main's TypeScript Type Check is red:
packages/cli/src/utils/lint-flow-patterns.test.ts:190—error TS7006: Parameter 'edges' implicitly has an 'any' type(introduced by #2279). The TS job builds the whole workspace, so this blocks CI for every open PR (incl. the ADR renumber #2280).One-line test-helper type annotation. No behavior change.
🤖 Generated with Claude Code