docs(adr): ADR-0071 correction — matrix already shipped, refocus on multi-hop joins#2293
Merged
Conversation
…on multi-hop
A code check before implementing the proposed matrix "P1" found matrix/across
pivoting already shipped end-to-end (DatasetMatrixTable in plugin-report +
ReportDefaultInspector type=matrix columns-across + report.form.ts), so the
ADR-0021 D2 matrix follow-up is satisfied — the first draft's "flattened" premise
was stale. Refocus ADR-0071 on the one remaining gap, multi-hop joins, which
native-sql-strategy.ts still rejects ("Only the first dotted hop is supported").
Adds a Correction section citing the matrix implementation.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
os-zhuang
added a commit
that referenced
this pull request
Jul 5, 2026
fix(app-shell): fast-fail Studio source editors to textarea when Monaco CDN is blocked (#2293) objectui@821500f5946fdd51d93479d0c4963d025c5b4de5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Before building the matrix "P1" from the freshly-merged ADR-0071 (#2289), I read the latest renderer — and matrix/across pivoting is already implemented end-to-end, so that part of the ADR was based on a stale ADR-0021-era note:
DatasetMatrixTable(plugin-report/src/DatasetReportRenderer.tsx): true cross-tab, server subtotals/grand-total, drill-down, with tests.ReportDefaultInspector.tsxexposestype: 'matrix'+ a "columns across" editor;report.form.tsrevealscolumnswhentype == 'matrix'.Multi-hop joins remain a real gap —
native-sql-strategy.ts:250still reads "Only the first dotted hop is supported (single-level relation)."What
Integrity correction to a doc merged minutes ago — no one has built on it yet.
🤖 Generated with Claude Code