fix(auth): SSO env-flag parsing + register-form empty state (ADR-0024 / cloud#551)#2400
Merged
Conversation
… / cloud#551) - plugin-auth: OS_OIDC_PROVIDER_ENABLED / OS_SSO_ENABLED / OS_SCIM_ENABLED now use the shared readBooleanEnv parser so true/1/yes/on all work (was literal 'true' only — OS_SSO_ENABLED=1 silently disabled the RP). + unit tests. - platform-objects: sys_sso_provider list view gets a per-object empty state pointing at "Register SSO Provider" (the shared identity-object copy wrongly said records can't be added here). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 11 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality polish from the cloud#551 SSO work.
OS_OIDC_PROVIDER_ENABLED/OS_SSO_ENABLED/OS_SCIM_ENABLEDnow use the sharedreadBooleanEnvparser, sotrue/1/yes/onall enable (was the literal'true'only —OS_SSO_ENABLED=1silently parsed as disabled, a repeated operator footgun). + unit tests (10 cases).sys_sso_providerlist view gets a per-object empty state ("No SSO providers yet" → "Register SSO Provider"); the shared identity-object copy wrongly said records can't be added here.Verified E2E:
OS_SSO_ENABLED=1→features.sso: true; the SSO Providers list shows the new empty state.🤖 Generated with Claude Code