docs(adr): ADR-0076 rev.6 — D10: "protocol" is a contract, distribute impls to domain packages#2427
Merged
Conversation
…l package; distribute impls to domain packages Extends the kernel review. Verified the central ObjectStackProtocolImplementation facade is the wrong end-state: it implements only 4/11 contract domains; analytics is duplicated and collides (both ObjectQLPlugin and AnalyticsServicePlugin register a 'analytics' service — a ~66-line facade copy vs service-analytics's ~1.8k-LOC engine); feed is already delegated; the domain services already exist. D10: reserve "protocol" for the contract (spec/api only, no *-protocol impl package); DataProtocol → transport, MetadataProtocol → a metadata-domain package (rename metadata-protocol → metadata-runtime), analytics/feed/realtime → their existing services (drop the facade's duplicates); dispatcher routes per slice. Refines D1 (metadata-protocol = intermediate) and completes D9. Cross-repo window. Docs only; empty changeset. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
size/s
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extends the kernel review in ADR-0076 (rev.6) with D10, per maintainer preference to keep it in one ADR.
D10 — "protocol" is a contract, not an implementation package
Verified the central
ObjectStackProtocolImplementationfacade is the wrong end-state:ObjectQLPluginandAnalyticsServicePluginregister a'analytics'service — the facade's ~66-lineanalyticsQueryvsservice-analytics's ~1.8k-LOC engine (3 strategies incl. native-SQL). Last-registered wins.IFeedService; the domain services (service-analytics/service-messaging/service-realtime) already exist.Target: reserve "protocol" for the contract (
@objectstack/spec/apionly — no*-protocolimpl package);DataProtocol→ transport,MetadataProtocol→ a metadata-domain package (renamemetadata-protocol→metadata-runtime), analytics/feed/realtime → their existing services (drop the facade's duplicates); the dispatcher routes each contract-slice to the owning service.Refines D1 (the
metadata-protocolpackage was an intermediate, not the end-state) and completes D9. Runs at the cross-repo window with D7 / Step 2.Scope
Docs only — edits
docs/adr/0076-objectql-core-tiering.md(Status → rev.6) + a refinement note on D1. No code. Empty changeset.🤖 Generated with Claude Code