feat(spec): add userActions.editInline toggle for inline record editing#2468
Merged
Conversation
Inline cell editing is a first-class, author-controlled list property, but UserActionsConfigSchema (the shared toggle set behind both a view's toolbar and a page's interfaceConfig.userActions) had no field for it — so the metadata-admin "Interface (list pages)" panel, which auto-renders these booleans as checkboxes, couldn't expose it. The runtime already honors it (objectui InterfaceListPage reads userActions.editInline -> inlineEdit). Add `editInline: boolean` (default false — a list is read-only unless the author opts in), sitting alongside `addRecordForm`. When on, cells edit with the field's type-aware widget (the same control the form uses). view.test.ts: assert the default (false) and the accepted (true) value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 90 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
editInline: boolean(defaultfalse) toUserActionsConfigSchema— the shared toggle set behind both a view's toolbar and a page'sinterfaceConfig.userActions.Why
Inline cell editing is meant to be a first-class, author-controlled list property, and the objectui runtime already honors it (
InterfaceListPagereadsuserActions.editInline === true→inlineEdit). But the schema had no field for it, so the metadata-admin "Interface (list pages)" panel — which auto-renders these booleans as checkboxes (sort/search/filter/rowHeight/addRecordForm) — had no toggle to expose. This adds the missing schema field so the panel renders an "Edit Inline" checkbox, sitting right alongsideaddRecordForm.Default
false: a list stays read-only unless the author opts in. When on, cells edit with the field's type-aware widget (the same control the form uses — select→dropdown, boolean→checkbox, date→picker, …).Tests
view.test.ts→UserActionsConfigSchemaasserts the new default (false) and the accepted (true) value.pnpm vitest run src/ui/view.test.ts -t UserActionsConfigSchema→ 3 passed.Downstream
objectui mirrors this in
ListViewSchema.userActions(objectstack-ai/objectui#feat/inline-edit-view-toggle). The metadata-panel checkbox appears once a runtime serves this spec via/meta/types.🤖 Generated with Claude Code