test(dogfood): runtime proof for ADR-0085 semantic roles over the served pipeline#2528
Merged
Conversation
…ved pipeline Adds showcase_semantic_zoo (canonical spellings) + showcase_semantic_zoo_legacy (deprecated spellings) as field_zoo-style fixtures, and a dogfood test that asserts against the real Hono app over HTTP: - highlightFields served verbatim + compactLayout transition mirror present (the assertion is deleted in the same PR that retires the alias); - deprecated compactLayout aliases onto highlightFields when served; - stageField:false arrives as a STRICT false (a falsy-dropping serializer or falsy-check renderer silently turns the stepper back on — the exact bug objectui#2168 fixed); - served metadata composes with the shared deriveFieldGroupLayout (§5): declared order, collapse passthrough, trailing ungrouped bucket; - the fixtures are real writable objects, not metadata ghosts. Red-proof: removing stageField:false from the fixture turns the strict-false assertion red (verified locally, then restored). Both packages are private — no changeset needed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckNo hand-written docs reference the 1 changed package(s). ✅ |
This was referenced Jul 3, 2026
os-zhuang
added a commit
that referenced
this pull request
Jul 3, 2026
…) (#2539) The ADR-0085 deprecation window is closed: consumers switched in objectui#2168, shipped via the console pin (#2526), one release soaked. - ObjectSchema drops the compactLayout declaration: create() rejects it (unknown key), lenient parse strips it — no silent aliasing either way. - normalizeSemanticRoleAliases loses both directions (alias + the #2521 back-fill mirror); served metadata carries highlightFields only. - 27 straggler system-object authors (plugins/services, missed by the #2521 sweep — the type gate caught the first one) renamed. - liveness ledger drops the compactLayout row; the dogfood mirror assertion (#2528) flips to expect ABSENCE, exactly as it was designed to force in the retirement PR. - Downstream smoke pin → hotcrm v1.2.2 (hotcrm#424, same rename). spec 6666 + dogfood 181 green; api-surface unchanged; check:liveness ✓. Closes #2536 Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solidifies the one-off browser verification of the ADR-0085 chain (#2521 / objectui#2168) into a permanent regression guard, in the
field_zoo(#2005) tradition.Fixtures
showcase_semantic_zoo(canonical:highlightFields+stageField: 'status'+fieldGroupswithcollapse: 'collapsed') andshowcase_semantic_zoo_legacy(deprecated:compactLayout+stageField: false, with astatus-named field that trips the stepper heuristic if suppression ever leaks).Assertions (real HTTP against the booted showcase app)
compactLayoutaliases ontohighlightFieldswhen served.stageField: falsearrives as a strictfalse— guards the falsy-check bug class objectui#2168 fixed.deriveFieldGroupLayout(§5) = declared order, collapse passthrough, trailing ungrouped bucket.Verification
stageField: falsefrom the fixture turns assertion 3 red (verified, then restored).examples/app-showcasetypecheck green.🤖 Generated with Claude Code