fix(spec): correct skill surface comment — ask is not the open-source/free surface#3286
Merged
Merged
Conversation
…urce/free surface The JSDoc on SkillSchema.surface described the default `'ask'` value as "the open-source/free surface." That is inaccurate: per cloud ADR-0025 the in-product agent runtime for BOTH `ask` and `build` ships in the cloud / Enterprise distribution (the open edition is MCP-only, BYO-AI). The `surface` value is authoring metadata — which agent a skill binds to — not an edition gate. Comment-only: the Zod `.describe()` string and the schema itself are unchanged, so generated reference docs and runtime behavior are unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LHQscZJ8NvXceSmsPNdTZd
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
added
the
skip-changeset
Claude
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 103 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 19, 2026 16:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
packages/spec/src/ai/skill.zod.ts里SkillSchema.surface的 JSDoc 把默认值'ask'注释为 "the open-source/free surface" —— 这是错的。按 cloud ADR-0025,
ask与build两个 in-product agent 运行时都属 cloud / Enterprise 分发,开源版是 MCP-only(BYO-AI),并没有内置的ask聊天。因此把ask说成"开源/免费 surface"与实际相反。这个矛盾此前在文档 PR #2649 里作为 finding 提示过;本 PR 在源头修正它。
改动
skill.zod.ts的surface字段 JSDoc:去掉错误的 "open-source/free surface" 说法,改为准确描述——ask是 data-console surface;并点明ask/build的 in-product 运行时按 ADR-0025 均属 cloud/Enterprise,surface值是授权元数据(某 skill 绑定到哪个 agent),不是版本门槛。仅改注释:Zod 的
.describe()字符串与 schema 本身未变,生成的 reference 文档与运行时行为不受影响。🤖 Generated with Claude Code
https://claude.ai/code/session_01LHQscZJ8NvXceSmsPNdTZd
Generated by Claude Code