feat(automation): publish configSchemas for the keyValue-capable nodes (designer parity, #3304)#3327
Merged
Conversation
…s (designer parity, #3304) Final #3304 increment (descriptor counterpart to objectui #2670 Phase 3). Now that the designer's schema adapter can render free-form maps (objectui #2708), the six keyValue-capable nodes publish structured configSchemas mirroring objectui's hardcoded field groups field-for-field: • assignment → assignments (open map; legacy array/bare shapes stay read-compatible, not offered for new authoring) • get_record → objectName (xRef object, required) / filter (map) / limit / outputVariable • create_record → objectName (required) / fields (map) / outputVariable • update_record → objectName (required) / filter (map) / fields (map) • delete_record → objectName (required) / filter (map) • screen → title / description (multiline) / fields repeater (visibleWhen = xExpression CEL column) / waitForInput / objectName (xRef) / idVariable / mode (enum) / defaults (map) The maps use the JSON-Schema open-object shape (`additionalProperties: true`, no fixed `properties`) and stay fully permissive — real metadata carries operator objects ({"$ne": null}), {var} templates, and non-string literals as values, so a stricter value schema would reject existing flows. Deliberately still schemaless (a node with no configSchema has NO online/offline divergence, and a partial schema would DROP editors the adapter cannot express): decision (virtual Target column from edges), wait (top-level waitEventConfig), script (actionType-conditional form), subflow (top-level timeoutMs). Verified: new config-schemas parity test (keyValue contract shape asserted per map; deliberate-schemaless asserted for decision/script); tsc clean; full @objectstack/service-automation suite green (335 tests). Descriptor metadata only — no runtime behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VuvxWgoadqryqBcjs7TpVi
github-actions
Bot
added
size/m
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 6 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
marked this pull request as ready for review
July 20, 2026 01:38
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final increment of #3304 (descriptor counterpart to objectui #2670 Phase 3). Follows #3313 (
loop), #3321 (map), and objectui #2708 (the keyValue schema-adapter mapping this depends on — merged).What
Six previously-schemaless nodes now publish a
configSchemamirroring objectui's hardcoded field group field-for-field:assignmentassignments→ open map (keyValue)get_recordobjectName(xRef object, required) /filter(map) /limit/outputVariablecreate_recordobjectName(required) /fields(map) /outputVariableupdate_recordobjectName(required) /filter(map) /fields(map)delete_recordobjectName(required) /filter(map)screentitle/description(multiline) /fieldsrepeater (visibleWhen=xExpressionCEL column) /waitForInput/objectName(xRef) /idVariable/mode(enum) /defaults(map)The maps use the JSON-Schema open-object idiom (
additionalProperties: true, no fixedproperties) — exactly what objectui #2708's adapter renders as the flat keyValue editor. Values are deliberately fully permissive: real metadata carries operator objects ({"$ne": null}),{var}templates, and non-string literals, so a stricter value schema would reject existing flows (the #15 discipline: the schema describes what the engine accepts, not what's pretty).Deliberately still schemaless
decision,wait,script,subflowstay on their hardcoded designer forms — a node with noconfigSchemahas no online/offline divergence (both render the hardcoded fallback), while a partial schema would drop editors the adapter can't express:decision— the virtual Target column is derived from out-edges, not stored configwait— fields live in the top-levelwaitEventConfigblock, outsideconfig.*script— the form is actionType-conditional (showWhen), which the adapter has no generic mapping forsubflow— carries a top-leveltimeoutMsfield a configSchema can't describeThis is asserted in the test (
decision/scriptexplicitly expected schemaless), so a future partial schema can't slip in silently.End state of #3304
loop,mapxExpressionmarkers (#3313, #3321)assignment, 4× CRUD,screendecision,wait,script,subflowWith this merged, #3304 can be closed: every node where server-driven parity is achievable without regression has it; the rest are documented design decisions rather than gaps.
Verification
config-schemas.test.ts: keyValue contract shape (type: 'object'+additionalProperties: true+ no fixedproperties) asserted per map; xRef/xExpression/enum/required assertions; deliberate-schemaless assertions fordecision/script.tsc --noEmitclean; full@objectstack/service-automationsuite green (335 tests, up from 331).Known inherited reds (main-wide, unrelated):
Check Changeset(console:major) and theESLintjob'scheck:release-notes(missing v16 page) — same as #3313/#3321.🤖 Generated with Claude Code
https://claude.ai/code/session_01VuvxWgoadqryqBcjs7TpVi
Generated by Claude Code