fix(plugin-approvals): ship _actions translations for the decision actions (objectui#2762 P0-3)#3416
Draft
os-zhuang wants to merge 1 commit into
Draft
fix(plugin-approvals): ship _actions translations for the decision actions (objectui#2762 P0-3)#3416os-zhuang wants to merge 1 commit into
os-zhuang wants to merge 1 commit into
Conversation
…tions (objectui#2762 P0-3) The Approval Center drawer rendered the sys_approval_request declared actions with their literal English labels in localized workspaces — the plugin's bundle had no _actions node for the console's _actions.<name>.label resolution to hit. Re-ran 'os i18n extract' against the plugin config and translated the new leaves for zh-CN / ja-JP / es-ES: all eight decision actions (label, confirmText, successMessage, param labels/helpText) plus the gaps the merge surfaced — the 'returned' status option, the sys_approval_action audit-action options, the attachments field, and the my_pending / recent view empty states. Refs objectui#2762 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
CI status: same org-wide Actions outage as objectstack-ai/objectui#2789 — every job here (Auto Label, ESLint, Type Check, Check PR Size, …) fails ~2s after creation with no runner ever assigned ( Generated by Claude Code |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Framework half of objectstack-ai/objectui#2762 P0-3 (动作标签 i18n): the Approval Center drawer showed English Approve / Reject / Reassign / Send back / Request info in a zh-CN workspace because
@objectstack/plugin-approvals' translation bundle covered fields and views but had no_actionsnode — the console's_actions.<name>.labelresolution had nothing to hit. (The UI half —DeclaredActionsBaractually resolving those keys — is objectstack-ai/objectui#2789.)os i18n extract packages/plugins/plugin-approvals/scripts/i18n-extract.config.ts --locales=zh-CN,ja-JP,es-ES --fill=default --objects-only --out=…), which merged_actionsscaffolding for all eightsys_approval_requestdecision actions into the four generated bundles, preserving every existing hand translation.label/confirmText/successMessageplus param labels/helpText forapproval_approve,approval_reject,approval_reassign,approval_send_back,approval_request_info,approval_remind,approval_recall,approval_resubmit. zh-CN terms match the console's existing vocabulary (通过 / 拒绝 / 转签 / 退回修改 / 退回补充 / 催办 / 撤回 / 重新提交).returnedstatus option, thesys_approval_action.actionaudit options (reassign/remind/request_info/comment/revise/resubmit/ooo_substitute), theattachmentsfield label/help, and themy_pending/recentview empty states.Verification
pnpm turbo build test --filter=@objectstack/plugin-approvalsgreen (8/8 tasks)Refs objectstack-ai/objectui#2762, objectstack-ai/objectui#2789
🤖 Generated with Claude Code
https://claude.ai/code/session_01Cu48mLFUdRBmMh8Z8R3CVz
Generated by Claude Code