Skip to content

feat(agents): pm-dispatch 升级判据收紧 — 明显的问题直接修,维护者持否决权而非审批权 - #4576

Merged
os-zhuang merged 3 commits into
mainfrom
claude/pm-agent-task-dispatch-r4cepu
Aug 2, 2026
Merged

feat(agents): pm-dispatch 升级判据收紧 — 明显的问题直接修,维护者持否决权而非审批权#4576
os-zhuang merged 3 commits into
mainfrom
claude/pm-agent-task-dispatch-r4cepu

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

目的

维护者反馈:objectui#3182(双版本 spec 依赖图)这类明显问题被挂成决策等确认——「明显的问题直接修,不是事事都需要我确认」。把升级判据收紧回写进 skill。

内容

.claude/skills/pm-dispatch/SKILL.md(step 8 前置判据):升级到维护者仅限两种情形——① 方案在产品语义/公开契约形状上真实分歧,且 issue、AGENTS.md、ADR、既有代码规范都给不出答案;② 修复需要破坏性/难回退动作(存量数据迁移形态、删除已发布能力、force 操作)。其余一律 PM 自决:事后报告 + 否决窗口,而非事前审批。并点名四类绝不升级、立即行动的情形:

  • 恢复既定不变量(契约族单版本、declared = enforced、gate 必须真的编译/运行它声称检查的东西)——双版本依赖图、失效绊线、未接线的门禁,发现即派发;「我可以恢复不变量吗」本身就是反模式;
  • 技术任务间的排序与依赖编排;
  • 验证策略(已定改动需要什么回归)——那是工作定界,不是决策;
  • 开发 agent 的 needs_decision 经 PM 复核落入上述类别的,PM 直接答复开发 agent,不再上传。

.claude/agents/os-dev.md:补记 GitHub API 正文净化器吞 TypeScript 泛型的实战陷阱与解法(尖括号后加空格,存后回读校验)。

备注

🤖 Generated with Claude Code

https://claude.ai/code/session_012C2cd7tL8QDoZ2QKN3djJ5


Generated by Claude Code

…intainer gets a veto window, not a permission gate

Maintainer feedback after #3182 sat waiting for confirmation: obvious
problems should just be fixed. Escalation now requires genuine product/
contract divergence with no repo-norm answer, or destructive/irreversible
action. Named non-escalation classes act immediately: restore-invariant
fixes (dual-version dependency graphs, inert tripwires, unwired gates),
sequencing, verification strategy, and dev needs_decision reports that
fall into those classes (the PM answers the dev directly). Also records
the GitHub body-sanitizer generics trap in the os-dev definition.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012C2cd7tL8QDoZ2QKN3djJ5
@vercel

vercel Bot commented Aug 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectstack Ignored Ignored Aug 2, 2026 8:52am

Request Review

@github-actions github-actions Bot added size/s documentation Improvements or additions to documentation tooling labels Aug 2, 2026
claude added 2 commits August 2, 2026 08:45
…ainer

Maintainer-reported OOM under parallel dispatch. Memory peaks are the
build/test phases, so heavy phases serialize on a container-wide flock
(/tmp/os-heavy-verify.lock) while editing stays parallel; plus heap caps
(NODE_OPTIONS max-old-space-size), scoped --filter builds/tests, capped
vitest/turbo workers, and worktree cleanup after the PR is up. PM-side:
batch:2 or mode:cloud for build-heavy tasks; OOM-killed agents redispatch
alone.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012C2cd7tL8QDoZ2QKN3djJ5
…-account claims, batch:5 operating point

- Multiple PM sessions shard by whole repo, never share one queue (batch
  independence is only checked within one PM's view; the merge queue is
  one lane regardless). Scaling order: bigger batch + mode:cloud first,
  repo shard second, same-queue multi-PM prohibited.
- Multiple GitHub accounts (colleagues' Claude Code) simplify claiming:
  assignee alone disambiguates across accounts; the claim-comment ritual
  is for sessions within one account. Partition by repo/label with a
  recorded assignment table.
- batch:5 recorded as the maintainer's operating point, riding on the
  container resource discipline.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012C2cd7tL8QDoZ2QKN3djJ5
@github-actions github-actions Bot added size/m and removed size/s labels Aug 2, 2026
@os-zhuang
os-zhuang marked this pull request as ready for review August 2, 2026 09:07
@os-zhuang
os-zhuang added this pull request to the merge queue Aug 2, 2026
Merged via the queue into main with commit b9b7310 Aug 2, 2026
17 checks passed
@os-zhuang
os-zhuang deleted the claude/pm-agent-task-dispatch-r4cepu branch August 2, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/m tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants