docs(changeset): C5 收敛的 changeset 补上与 #4664 placement 的区分说明 (#4653) - #4679
Merged
Conversation
PR #4662 合并时,这段说明还在未提交状态(worktree 被清理时一并丢失), 故补一个 changeset-only 的跟进。无代码改动。 同窗口的 #4664 退休了 `app.contextSelectors[].placement`,而它的退休说明 里写着「`location` 曾是 `placement` 的别名」。Studio 插件的面板贡献点恰好 也有一个 `location` 键(`studio/PanelContribution.location`),两者在不同 schema 上、取值域不同、互不相关 —— 但对着 v17 release notes 逐条读的作者 很容易把两件事连起来,以为 `contributes.panels[].location` 也要改。 changeset 里主动写清这个区分,挡掉误解;同时记下另外四个退休键与 #4668 与 `activationEvents` 均无语义交叉。 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M9uWvoEp9CoLzYjNExj9sL
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
os-zhuang
marked this pull request as ready for review
August 2, 2026 16:37
os-zhuang
enabled auto-merge
August 2, 2026 16:38
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
跟进 #4653 / PR #4662(已合并为
65ca83a58)。Changeset-only,零代码改动。为什么有这个 PR
协调者要求在 changeset 里交代「#4664 退的五个 key 与
activationEvents是否有语义交叉」(参照 C8 对mapping.errorPolicy的处理)。我查出了一个确实容易被误读的near-miss 并写好了说明,但那次编辑还处于未提交状态时 PR #4662 就被合并、worktree 随即被清理,这段文字因此没能随 #4662 落地。补上。补的是什么
同窗口的 #4664 退休了
app.contextSelectors[].placement,其退休说明里写着「location曾是placement的别名」。而 Studio 插件的面板贡献点恰好也有一个location键:ui/App.contextSelectors[].placement(别名location)studio/PanelContribution.locationsidebar_header/topbar)bottom/right/modal)对着 v17 release notes 逐条读的插件作者很容易把两件事连起来,以为
contributes.panels[].location也要跟着改 —— 实际不需要。changeset 主动挡掉这个误解。同时记下:另外四个退休键(
mapping.extractQuery/mapping.errorPolicy/mapping.batchSize/app.contextSelectors[].includeAll)以及 #4668(ADR-0119 D2 migration journal)与activationEvents均无语义交叉(已逐一核过,#4668 全 diff 对ActivationEvent/activationEvents零命中)。时效
.changeset/pre.json仍是mode: pre/tag: rc,converge-activation-event-schema.md尚未被消费,所以这段文字仍能进入 v17 release notes。changeset pre exit之后就来不及了。顺带汇报:main 上 C5 的落地状态已复核,健康
PR #4662 经合并队列 rebase 后落在 main 为
65ca83a58(SHA 与我推的52a5de34a不同,内容一致)。队列替我解了authorable-surface.json/api-surface.json两个生成物的冲突 —— 我在 main 上重新验了一遍:build→gen:schema→gen:api-surface后git diff空,即 main 上这两个生成物确实是生成器的输出,队列的自动解决没有产生漂移(这正是我在authorable-surface.json在 main 上不是gen:schema的输出 —— 基线手编的字节级实锤(#4650 加固建议) #4663 里建议的那条检查)。studio/ActivationEvent:pattern/:type在;feat(spec)!: 退役五个「lint 永远无法告警」的键,并接通 doc.tags (#4509) #4664 退的五个键正确缺席;feat(core,platform-objects,spec): ADR-0119 D2 — the migration-journal runner (#4617) #4668 的system/Migration*键在。总计 8260 个 key。check:dual-source-exports→21 accepted dual-source,基线文件 21 行。🤖 Generated with Claude Code
https://claude.ai/code/session_01M9uWvoEp9CoLzYjNExj9sL
Generated by Claude Code