Skip to content

Fix module resolution and Vite bundling for browser builds #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 3 commits into from
Feb 3, 2026
Merged

Fix module resolution and Vite bundling for browser builds #498

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6d90d4
Initial plan
Copilot Feb 3, 2026
6dc6e9a
Fix module resolution for example packages - add exports field
Copilot Feb 3, 2026
1e0c9b0
Fix Vite browser bundling - make Node.js module imports conditional
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions examples/app-crm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
"version": "0.9.0",
"description": "Example CRM implementation using ObjectStack Protocol",
"private": true,
"main": "./objectstack.config.ts",
"types": "./objectstack.config.ts",
"exports": {
".": "./objectstack.config.ts",
"./objectstack.config": "./objectstack.config.ts"
},
"scripts": {
"dev": "objectstack dev",
"build": "objectstack compile objectstack.config.ts dist/crm.json",
Expand Down
2 changes: 1 addition & 1 deletion examples/app-react-crud/src/mocks/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { ObjectQLPlugin } from '@objectstack/objectql';
import { InMemoryDriver } from '@objectstack/driver-memory';
import { MSWPlugin } from '@objectstack/plugin-msw';
// import appConfig from '../../objectstack.config';
import todoConfig from '@objectstack/example-todo/objectstack.config';
import todoConfig from '@example/app-todo/objectstack.config';

let kernel: ObjectKernel | null = null;

Expand Down
6 changes: 6 additions & 0 deletions examples/app-todo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
"version": "0.9.0",
"description": "Example Todo App using ObjectStack Protocol",
"private": true,
"main": "./objectstack.config.ts",
"types": "./objectstack.config.ts",
"exports": {
".": "./objectstack.config.ts",
"./objectstack.config": "./objectstack.config.ts"
},
"scripts": {
"dev": "objectstack dev",
"build": "objectstack compile objectstack.config.ts dist/objectstack.json",
Expand Down
5 changes: 5 additions & 0 deletions examples/plugin-bi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
"name": "@example/plugin-bi",
"version": "0.9.0",
"main": "src/index.ts",
"types": "src/index.ts",
"exports": {
".": "./src/index.ts",
"./objectstack.config": "./objectstack.config.ts"
},
Comment on lines 4 to +9

Copilot AI Feb 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent package exports configuration. The "main" field points to "src/index.ts" (a plugin implementation), while the "exports" includes "./objectstack.config" pointing to "objectstack.config.ts" (a manifest). This differs from the pattern used in app-todo and app-crm where "main" points to "objectstack.config.ts".

Since app-host imports from "@example/plugin-bi/objectstack.config", the exports configuration is correct, but the "main" field should also point to "objectstack.config.ts" for consistency, or the package should clarify its dual purpose (both plugin implementation and manifest export).

Copilot uses AI. Check for mistakes.
"license": "MIT",
"private": true,
"scripts": {
Expand Down
Loading