fix: update sidebar toggle button locator to ensure visibility at desktop widths

Author: hotlong

e2e/console-rendering.spec.ts

@@ -73,10 +73,15 @@ test.describe('Console Rendering', () => {
     // If it's missing, the app may hang during bootstrap.
     const response = await page.request.get(`${CONSOLE_BASE}/mockServiceWorker.js`);
 
-    // In production builds without MSW, 404 is acceptable.
-    // But if the build includes it, it must be valid JS.
+    // In production builds without MSW, the asset may be absent. The static
+    // server returns the SPA fallback (index.html) for unknown paths, which
+    // is a 200 with `text/html`. Treat that as "MSW not bundled" and skip.
     if (response.ok()) {
       const contentType = response.headers()['content-type'] || '';
+      if (contentType.includes('text/html')) {
+        // SPA fallback — mockServiceWorker.js is not bundled in this build.
+        return;
+      }
       expect(contentType).toContain('javascript');
     }
   });

e2e/sidebar-text-visibility.spec.ts

@@ -46,8 +46,10 @@ test.describe('Sidebar Text Visibility', () => {
     const sidebar = page.locator('[data-sidebar="sidebar"]').first();
     await expect(sidebar).toBeVisible({ timeout: SIDEBAR_VISIBLE_TIMEOUT });
 
-    // Find the sidebar toggle button (desktop trigger rendered by AppShell)
-    const toggleButton = page.locator('[data-sidebar="trigger"]').first();
+    // Find the sidebar toggle button (desktop trigger rendered in SidebarFooter).
+    // AppHeader also renders a mobile-only `md:hidden` trigger that is not
+    // visible at desktop viewport widths, so filter by visibility.
+    const toggleButton = page.locator('[data-sidebar="trigger"]:visible').first();
     await expect(toggleButton).toBeVisible({ timeout: SIDEBAR_VISIBLE_TIMEOUT });
 
     // Get the parent sidebar element that has data-state attribute
@@ -126,7 +128,7 @@ test.describe('Sidebar Text Visibility', () => {
     const sidebar = page.locator('[data-sidebar="sidebar"]').first();
     await expect(sidebar).toBeVisible({ timeout: SIDEBAR_VISIBLE_TIMEOUT });
 
-    const toggleButton = page.locator('[data-sidebar="trigger"]').first();
+    const toggleButton = page.locator('[data-sidebar="trigger"]:visible').first();
     await expect(toggleButton).toBeVisible({ timeout: SIDEBAR_VISIBLE_TIMEOUT });
 
     const sidebarGroup = page.locator('.group[data-collapsible="icon"]').first();