fix(share): correct public share link URL + ShareDialog audiences (#1784)

* fix(share): align ShareDialog audiences to framework contract

Offer only link_only + signed_in (the audiences needing no extra input
and allowed by ai_conversations); drop workspace/email_allowlist which
the framework ShareLinkService rejects.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(share): point the public share URL at the console-mounted route

SharedRecordPage lives under the console SPA basename (/_console/s/:token),
so ShareDialog's default ${origin}/s/:token produced links that 404'd for
recipients. AiChatPage now passes publicBaseUrl derived from the injected
<base href> (matching App.tsx resolveBasename), so copied links resolve.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: os-zhuang

packages/app-shell/src/console/ai/AiChatPage.tsx

@@ -496,6 +496,23 @@ export function AiChatPage({ apiBase: apiBaseProp, defaultAgent: defaultAgentPro
     [apiBase],
   );
 
+  // Public share-link landing base. SharedRecordPage lives UNDER the console
+  // SPA basename (e.g. `/_console/s/:token`), so the ShareDialog default of
+  // `${origin}/s/:token` 404s for recipients. Derive the base from the SPA's
+  // BASE_URL so the copyable link points at the actually-served route.
+  const publicShareBase = useMemo(() => {
+    if (typeof window === 'undefined' || typeof document === 'undefined') return undefined;
+    // Mirror the console's own basename resolution (App.tsx resolveBasename):
+    // the published SPA uses a relative Vite base, so the mount path is carried
+    // by the injected `<base href>` tag, NOT import.meta.env.BASE_URL.
+    let base = '';
+    try {
+      const href = document.querySelector('base')?.getAttribute('href');
+      if (href) base = new URL(href, window.location.origin).pathname.replace(/\/+$/, '');
+    } catch { /* no <base> → root-mounted SPA */ }
+    return `${window.location.origin}${base}/s`;
+  }, []);
+
   // New-conversation race guard. On an IN-SPA `/ai?new=1` navigation the
   // URL-mirroring effect below fires in the SAME commit as the hook's effect,
   // with this render's (stale) `conversationId` still in its closure — the
@@ -631,6 +648,7 @@ export function AiChatPage({ apiBase: apiBaseProp, defaultAgent: defaultAgentPro
           recordId={conversationId}
           recordLabel="this conversation"
           apiBase={restApiBase}
+          publicBaseUrl={publicShareBase}
         />
       )}
       <div className="flex min-h-0 flex-1 w-full bg-muted/20">

packages/components/src/share/ShareDialog.tsx

@@ -41,7 +41,7 @@ import { Badge } from '../ui/badge';
 import { cn } from '../lib/utils';
 
 export type ShareLinkPermission = 'view' | 'comment' | 'edit';
-export type ShareLinkAudience = 'link_only' | 'signed_in' | 'workspace' | 'email_allowlist';
+export type ShareLinkAudience = 'public' | 'link_only' | 'signed_in' | 'email';
 
 export interface ShareLink {
   id: string;
@@ -106,11 +106,14 @@ const EXPIRY_OPTIONS: { label: string; value: number | null }[] = [
   { label: 'Never', value: null },
 ];
 
+// Audience values match the framework's ShareLinkAudience contract
+// (@objectstack/spec). Only the two that need no extra input are offered;
+// 'email' (allowlist) / 'public' require UI not yet built. The target
+// object's `publicSharing.allowedAudiences` further constrains this — the
+// server returns 422 AUDIENCE_NOT_ALLOWED if a value is not permitted.
 const AUDIENCE_OPTIONS: { value: ShareLinkAudience; label: string; help: string }[] = [
   { value: 'link_only', label: 'Anyone with the link', help: 'No sign-in required' },
   { value: 'signed_in', label: 'Signed-in users', help: 'Must be logged in to view' },
-  { value: 'workspace', label: 'Workspace members', help: 'Same tenant only' },
-  { value: 'email_allowlist', label: 'Specific emails', help: 'Restricted to listed addresses' },
 ];
 
 function buildPublicUrl(base: string | undefined, token: string): string {