Skip to content

Commit 08a93fe

Browse files
os-zhuangclaude
andcommitted
docs(app-shell): the wait-key retirement lands in spec 17.0.0, not the "18" its tombstone claims (#3101)
`zodKeys`' TSDoc named "spec 18" as the bump that arms the `wait` panel, copied from framework#4198's own prose. There is no 18 to wait for: `@objectstack/spec` publishes `latest` 16.1.0 / `rc` 17.0.0-rc.0, and changesets computes a pre-release train off the last *published* major — so the retirement's `major` changeset resolves to 17.0.0-rc.x, not 18. framework main already carries both tombstones (ab1633122) with `PROTOCOL_VERSION = '17.0.0'`. Comment only; the filter and the assertions are unchanged. The correction matters because it names the trigger: the panel fires on the next rc this repo installs, not on a major the current release train cannot produce. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 0947b3c commit 08a93fe

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

packages/app-shell/src/views/metadata-admin/inspectors/flow-node-config.spec-reconciliation.test.ts

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,17 @@ const SCRIPT_INVOKE_FUNCTION_ACTION_TYPE = spec.SCRIPT_INVOKE_FUNCTION_ACTION_TY
5252
* marks it with a `[REMOVED]` description), but it is NOT part of the
5353
* authorable contract — a form field writing one produces metadata the loader
5454
* rejects. Counting tombstones as contract keys would false-pass exactly that
55-
* drift (e.g. `waitEventConfig.timeoutMs` / `.onTimeout`, retired at spec 18
56-
* by framework#4198 — this filter is what makes the `wait` panel fire on that
57-
* bump until the form drops the two fields).
55+
* drift (e.g. `waitEventConfig.timeoutMs` / `.onTimeout`, retired by
56+
* framework#4198 — this filter is what makes the `wait` panel fire on the spec
57+
* bump that carries their tombstones, until the form drops the two fields).
58+
*
59+
* That bump is a **17.0.0-rc refresh**, not the "spec 18" the tombstone text
60+
* itself names: changesets computes a pre-release train off the last
61+
* *published* major (`@objectstack/spec` latest is 16.1.0, `rc` is
62+
* 17.0.0-rc.0), so the retirement's `major` resolves to **17.0.0** — and
63+
* framework main carries the tombstones with `PROTOCOL_VERSION = '17.0.0'`.
64+
* The trigger is the next rc this repo installs, not a major that the current
65+
* release train cannot produce. Tracked in #3101.
5866
*/
5967
function zodKeys(schema: unknown): string[] {
6068
const shape = (schema as { shape?: Record<string, unknown> }).shape;

0 commit comments

Comments
 (0)