Skip to content

Commit 0e84e99

Browse files
Copilothotlong
andcommitted
fix: move renderStart after debugTime for accurate perf measurement
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent c61b660 commit 0e84e99

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

packages/core/src/utils/debug-collector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export class DebugCollector {
9494
this.entries = this.entries.slice(-MAX_ENTRIES);
9595
}
9696
for (const fn of this.subscribers) {
97-
try { fn(entry); } catch { /* swallow subscriber errors */ }
97+
try { fn(entry); } catch { /* subscriber errors must not break debug flow */ }
9898
}
9999
}
100100
}

packages/react/src/SchemaRenderer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,8 @@ export const SchemaRenderer = forwardRef<any, { schema: SchemaNode } & Record<st
230230
}
231231
}
232232

233-
const renderStart = isDebug ? performance.now() : 0;
234233
debugTime(`render:${evaluatedSchema.type}:${evaluatedSchema.id ?? 'anon'}`);
234+
const renderStart = isDebug ? performance.now() : 0;
235235
const rendered = (
236236
<SchemaErrorBoundary componentType={evaluatedSchema.type}>
237237
{React.createElement(Component, {

0 commit comments

Comments
 (0)