Skip to content

Commit 0e90e6b

Browse files
Copilothotlong
andcommitted
Extract magic numbers in test mock data per code review
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent cbd1d4d commit 0e90e6b

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

apps/console/src/__tests__/PluginsIntegration.test.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,11 @@ describe('Plugins Integration Test', () => {
7070
}
7171
};
7272

73+
const ONE_DAY_MS = 24 * 60 * 60 * 1000;
7374
const mockData = [
74-
{ id: '1', name: 'Task 1', status: 'new', due_date: new Date(Date.now() + 86400000).toISOString() },
75-
{ id: '2', name: 'Task 2', status: 'working', due_date: new Date(Date.now() + 172800000).toISOString() },
76-
{ id: '3', name: 'Task 3', status: 'done', due_date: new Date(Date.now() + 259200000).toISOString() }
75+
{ id: '1', name: 'Task 1', status: 'new', due_date: new Date(Date.now() + ONE_DAY_MS).toISOString() },
76+
{ id: '2', name: 'Task 2', status: 'working', due_date: new Date(Date.now() + 2 * ONE_DAY_MS).toISOString() },
77+
{ id: '3', name: 'Task 3', status: 'done', due_date: new Date(Date.now() + 3 * ONE_DAY_MS).toISOString() }
7778
];
7879

7980
const mockDataSource = {

0 commit comments

Comments
 (0)