You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: Airtable-style toolbar opt-in defaults & remove duplicate record count
- Change showHideFields/showColor/showDensity from opt-out (!== false) to opt-in (=== true)
- Remove duplicate record-count-footer from ObjectView.tsx
- Update @default JSDoc in NamedListView and ListViewSchema types
- Update 11 tests to match new default behavior
- Document fix in ROADMAP.md
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
**Root Cause (1 — Toolbar defaults):**`showHideFields`, `showColor`, and `showDensity` in `ListView.tsx` used opt-out logic (`!== false`), making secondary toolbar buttons visible by default. Airtable hides these controls unless explicitly enabled.
1093
+
1094
+
**Fix:** Changed default logic from `!== false` (opt-out) to `=== true` (opt-in) for `showHideFields`, `showColor`, and `showDensity` in the `toolbarFlags` computation. Updated `@default` JSDoc comments in `NamedListView` and `ListViewSchema` interfaces from `@default true` to `@default false`.
1095
+
1096
+
**Root Cause (2 — Duplicate record count):** Both `ListView.tsx` (`record-count-bar`) and `ObjectView.tsx` (`record-count-footer`) independently rendered the record count at the bottom, causing duplicate display.
1097
+
1098
+
**Fix:** Removed the `record-count-footer` from `ObjectView.tsx` since `ListView` already renders the authoritative `record-count-bar`.
1099
+
1100
+
**Tests:** Updated 11 tests across `ListView.test.tsx` and `ObjectView.test.tsx`. All 112 ListView tests and 32 ObjectView tests pass.
0 commit comments