Skip to content

Commit 11b82f6

Browse files
authored
Merge pull request #381 from objectstack-ai/copilot/fix-ci-test-build
2 parents 13820e8 + 63e3a43 commit 11b82f6

12 files changed

Lines changed: 51 additions & 20 deletions

File tree

.gitkeep-build-fixed

Whitespace-only changes.

apps/console/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,12 @@
3333
"@object-ui/plugin-calendar": "workspace:*",
3434
"@object-ui/plugin-charts": "workspace:*",
3535
"@object-ui/plugin-dashboard": "workspace:*",
36+
"@object-ui/plugin-detail": "workspace:*",
3637
"@object-ui/plugin-form": "workspace:*",
3738
"@object-ui/plugin-gantt": "workspace:*",
3839
"@object-ui/plugin-grid": "workspace:*",
3940
"@object-ui/plugin-kanban": "workspace:*",
41+
"@object-ui/plugin-list": "workspace:*",
4042
"@object-ui/react": "workspace:*",
4143
"@object-ui/types": "workspace:*",
4244
"@objectstack/client": "^0.9.0",

packages/plugin-chatbot/src/renderer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ ComponentRegistry.register('chatbot-enhanced',
213213
})) || []
214214
);
215215

216-
const handleSendMessage = (content: string, files?: File[]) => {
216+
const handleSendMessage = (content: string, _files?: File[]) => {
217217
const userMessage: ChatMessage = {
218218
id: generateUniqueId('msg'),
219219
role: 'user',

packages/plugin-dashboard/src/DashboardGridLayout.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,15 +89,16 @@ export const DashboardGridLayout: React.FC<DashboardGridLayoutProps> = ({
8989
const getComponentSchema = React.useCallback((widget: DashboardWidgetSchema) => {
9090
if (widget.component) return widget.component;
9191

92-
if (widget.type === 'bar' || widget.type === 'line' || widget.type === 'area' || widget.type === 'pie' || widget.type === 'donut') {
92+
const widgetType = (widget as any).type;
93+
if (widgetType === 'bar' || widgetType === 'line' || widgetType === 'area' || widgetType === 'pie' || widgetType === 'donut') {
9394
const dataItems = Array.isArray((widget as any).data) ? (widget as any).data : (widget as any).data?.items || [];
9495
const options = (widget as any).options || {};
9596
const xAxisKey = options.xField || 'name';
9697
const yField = options.yField || 'value';
9798

9899
return {
99100
type: 'chart',
100-
chartType: widget.type,
101+
chartType: widgetType,
101102
data: dataItems,
102103
xAxisKey: xAxisKey,
103104
series: [{ dataKey: yField }],
@@ -106,7 +107,7 @@ export const DashboardGridLayout: React.FC<DashboardGridLayoutProps> = ({
106107
};
107108
}
108109

109-
if (widget.type === 'table') {
110+
if (widgetType === 'table') {
110111
return {
111112
type: 'data-table',
112113
...(widget as any).options,
@@ -162,7 +163,7 @@ export const DashboardGridLayout: React.FC<DashboardGridLayoutProps> = ({
162163
{schema.widgets?.map((widget, index) => {
163164
const widgetId = widget.id || `widget-${index}`;
164165
const componentSchema = getComponentSchema(widget);
165-
const isSelfContained = widget.type === 'metric';
166+
const isSelfContained = (widget as any).type === 'metric';
166167

167168
return (
168169
<div key={widgetId} className="h-full">

packages/plugin-dashboard/src/DashboardRenderer.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ export const DashboardRenderer = forwardRef<HTMLDivElement, { schema: DashboardS
4343
if (widget.component) return widget.component;
4444

4545
// Handle Shorthand Registry Mappings
46-
if (widget.type === 'bar' || widget.type === 'line' || widget.type === 'area' || widget.type === 'pie' || widget.type === 'donut') {
46+
const widgetType = (widget as any).type;
47+
if (widgetType === 'bar' || widgetType === 'line' || widgetType === 'area' || widgetType === 'pie' || widgetType === 'donut') {
4748
// Extract data from 'data.items' or 'data' array
4849
const dataItems = Array.isArray((widget as any).data) ? (widget as any).data : (widget as any).data?.items || [];
4950

@@ -54,7 +55,7 @@ export const DashboardRenderer = forwardRef<HTMLDivElement, { schema: DashboardS
5455

5556
return {
5657
type: 'chart',
57-
chartType: widget.type,
58+
chartType: widgetType,
5859
data: dataItems,
5960
xAxisKey: xAxisKey,
6061
series: [{ dataKey: yField }],
@@ -63,7 +64,7 @@ export const DashboardRenderer = forwardRef<HTMLDivElement, { schema: DashboardS
6364
};
6465
}
6566

66-
if (widget.type === 'table') {
67+
if (widgetType === 'table') {
6768
// Map to ObjectGrid
6869
return {
6970
type: 'data-table',
@@ -79,7 +80,7 @@ export const DashboardRenderer = forwardRef<HTMLDivElement, { schema: DashboardS
7980
}, [widget]);
8081

8182
// Check if the widget is self-contained (like a Metric Card) to avoid double borders
82-
const isSelfContained = widget.type === 'metric';
83+
const isSelfContained = (widget as any).type === 'metric';
8384

8485
if (isSelfContained) {
8586
return (

packages/plugin-detail/src/DetailView.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,11 @@ export const DetailView: React.FC<DetailViewProps> = ({
6060
onEdit();
6161
} else if (schema.editUrl) {
6262
window.location.href = schema.editUrl;
63-
} else {
64-
setEditMode(true);
6563
}
64+
// TODO: Implement inline edit mode
65+
// else {
66+
// setEditMode(true);
67+
// }
6668
}, [onEdit, schema.editUrl]);
6769

6870
const handleDelete = React.useCallback(() => {

packages/plugin-detail/tsconfig.json

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,17 @@
11
{
2-
"extends": "../../tsconfig.base.json",
2+
"extends": "../../tsconfig.json",
33
"compilerOptions": {
4-
"outDir": "./dist",
5-
"rootDir": "./src"
4+
"outDir": "dist",
5+
"jsx": "react-jsx",
6+
"baseUrl": ".",
7+
"paths": {
8+
"@/*": ["src/*"]
9+
},
10+
"noEmit": false,
11+
"declaration": true,
12+
"composite": true,
13+
"declarationMap": true,
14+
"skipLibCheck": true
615
},
716
"include": ["src"],
817
"exclude": ["node_modules", "dist", "**/*.test.ts", "**/*.test.tsx"]

packages/plugin-kanban/src/KanbanEnhanced.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ function SortableCard({ card }: { card: KanbanCard }) {
9999
)
100100
}
101101

102-
function VirtualizedCardList({ cards, parentRef }: { cards: KanbanCard[]; parentRef: React.RefObject<HTMLDivElement> }) {
102+
function VirtualizedCardList({ cards, parentRef }: { cards: KanbanCard[]; parentRef: React.RefObject<HTMLDivElement | null> }) {
103103
const rowVirtualizer = useVirtualizer({
104104
count: cards.length,
105105
getScrollElement: () => parentRef.current,

packages/plugin-kanban/src/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
import React, { Suspense } from 'react';
1010
import { ComponentRegistry } from '@object-ui/core';
1111
import { Skeleton } from '@object-ui/components';
12+
import { ObjectKanban } from './ObjectKanban';
1213

1314
// Export types for external use
1415
export type { KanbanSchema, KanbanCard, KanbanColumn } from './types';
15-
export { ObjectKanban } from './ObjectKanban';
16+
export { ObjectKanban };
1617
export type { ObjectKanbanProps } from './ObjectKanban';
1718

1819
// 🚀 Lazy load the implementation files

packages/plugin-list/src/ListView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export const ListView: React.FC<ListViewProps> = ({
2626
schema,
2727
className,
2828
onViewChange,
29-
onFilterChange,
29+
onFilterChange: _onFilterChange,
3030
onSortChange,
3131
onSearchChange,
3232
}) => {

0 commit comments

Comments
 (0)