fix: address CI failures and PR review comments

- Fix RecordDetailEdit test: only pass 3rd arg to findOne when $expand
  params exist (avoids undefined 3rd arg assertion failure)
- ListView: reset objectDefLoaded + objectDef when objectName changes
  to prevent stale $expand on navigation
- DetailView: clear objectSchema + data when starting new fetch cycle
  to prevent stale metadata on navigation
- DetailSection: merge missing metadata props (options, reference_to,
  reference_field, etc.) from objectSchema even when field.type is set
- data-objectstack: detect /api/v1 suffix in baseUrl to avoid doubling
  the path prefix in rawFindWithPopulate()
- ROADMAP.md: update adapter descriptions to reflect raw GET + populate
  approach instead of data.query() POST
- Add test for baseUrl /api/v1 double-prefix prevention

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

ROADMAP.md

@@ -1380,9 +1380,9 @@ All 313 `@object-ui/fields` tests pass.
 
 - **ListView** (`packages/plugin-list/src/ListView.tsx`): Added `objectDefLoaded` state flag. Data fetch effect is gated on `objectDefLoaded` so the first fetch always includes correct `$expand` parameters. The `objectDef` fetch effect sets the flag in `finally` block to handle both success and error cases.
 - **DetailView** (`packages/plugin-detail/src/DetailView.tsx`): Added `objectSchema` state. Data fetch effect now calls `getObjectSchema()` first, computes `$expand` via `buildExpandFields()`, and passes the params to `findOne()`. The resolved `objectSchema` is passed to `DetailSection` components.
-- **DetailSection** (`packages/plugin-detail/src/DetailSection.tsx`): Added optional `objectSchema` prop. When `field.type` is not set, the field is enriched with type, options, currency, precision, format, reference_to, and reference_field from `objectSchema` before selecting a CellRenderer. Explicit `field.type` always takes precedence over objectSchema.
-- **ObjectStackAdapter `find()`** (`packages/data-objectstack/src/index.ts`): When `$expand` is present, routes to `client.data.query()` (POST) which supports the full query AST including expand. Added `buildQueryAST()` and `normalizeQueryResult()` private helpers.
-- **ObjectStackAdapter `findOne()`** (`packages/data-objectstack/src/index.ts`): When `$expand` is present, uses `client.data.query()` with `['_id', '=', id]` filter and `expand` map. Falls back to `client.data.get()` when no expand is needed.
+- **DetailSection** (`packages/plugin-detail/src/DetailSection.tsx`): Added optional `objectSchema` prop. Fields are enriched with missing metadata (options, currency, precision, format, reference_to, reference_field) from `objectSchema` regardless of whether `field.type` is explicitly set. When `field.type` is not set, the type is also resolved from objectSchema. Explicit `field.type` always takes precedence for the resolved type.
+- **ObjectStackAdapter `find()`** (`packages/data-objectstack/src/index.ts`): When `$expand` is present, routes through `rawFindWithPopulate()` which issues a raw GET request with a `populate=` query parameter derived from the `$expand` field names. The server's REST plugin routes `GET /data/:object` to `findData()` which processes `populate` (comma-separated string) for lookup expansion. Falls back to `client.data.find()` when no expand is needed.
+- **ObjectStackAdapter `findOne()`** (`packages/data-objectstack/src/index.ts`): When `$expand` is present, uses the same `rawFindWithPopulate()` mechanism with `filter={"_id":"..."}` and `populate=` to fetch the single record with expanded lookup fields. Falls back to `client.data.get()` when no expand is needed.
 
 **Tests:** 15 new tests added (2 ListView, 3 DetailView, 4 DetailSection, 8 data-objectstack). All 505 plugin tests + 94 data-objectstack tests pass.
 

packages/data-objectstack/src/expand.test.ts

@@ -215,5 +215,31 @@ describe('ObjectStackAdapter $expand support', () => {
 
       expect(result.data).toHaveLength(1);
     });
+
+    it('should not double /api/v1 when baseUrl already includes it', async () => {
+      mockFetch.mockResolvedValue({
+        ok: true,
+        json: () => Promise.resolve({ records: [], total: 0 }),
+      });
+
+      // Create adapter with /api/v1 in baseUrl
+      const apiAdapter = new ObjectStackAdapter({
+        baseUrl: 'http://localhost:3000/api/v1',
+        autoReconnect: false,
+        fetch: mockFetch,
+      });
+      (apiAdapter as any).client = mockClient;
+      (apiAdapter as any).connected = true;
+
+      await apiAdapter.find('order', {
+        $expand: ['customer'],
+      });
+
+      expect(mockFetch).toHaveBeenCalled();
+      const fetchUrl = mockFetch.mock.calls[0][0] as string;
+      // Should be /api/v1/data/order not /api/v1/api/v1/data/order
+      expect(fetchUrl).toBe('http://localhost:3000/api/v1/data/order?populate=customer');
+      expect(fetchUrl).not.toContain('/api/v1/api/v1');
+    });
   });
 });

packages/data-objectstack/src/index.ts

@@ -583,7 +583,10 @@ export class ObjectStackAdapter<T = unknown> implements DataSource<T> {
 
     const baseUrl = this.baseUrl.replace(/\/$/, '');
     const qs = queryParams.toString();
-    const url = `${baseUrl}/api/v1/data/${resource}${qs ? `?${qs}` : ''}`;
+    // Avoid doubling /api/v1 if baseUrl already includes it
+    const hasApiVersionSuffix = /\/api\/v\d+$/i.test(baseUrl);
+    const dataPath = hasApiVersionSuffix ? '/data' : '/api/v1/data';
+    const url = `${baseUrl}${dataPath}/${resource}${qs ? `?${qs}` : ''}`;
 
     const headers: Record<string, string> = {
       'Content-Type': 'application/json',

packages/plugin-detail/src/DetailSection.tsx

@@ -78,12 +78,13 @@ export const DetailSection: React.FC<DetailSectionProps> = ({
 
     const displayValue = (() => {
       if (value === null || value === undefined) return '-';
-      // Enrich field with objectSchema metadata when field.type is not set
+      // Enrich field with objectSchema metadata — merge missing properties
+      // even when field.type is explicitly set (e.g., type: 'lookup' without reference_to)
       const objectDefField = objectSchema?.fields?.[field.name];
       const resolvedType = field.type || objectDefField?.type;
       const enrichedField: Record<string, any> = { ...field };
-      if (!field.type && objectDefField) {
-        if (objectDefField.type) enrichedField.type = objectDefField.type;
+      if (objectDefField) {
+        if (!enrichedField.type && objectDefField.type) enrichedField.type = objectDefField.type;
         if (objectDefField.options && !enrichedField.options) enrichedField.options = objectDefField.options;
         if (objectDefField.currency && !enrichedField.currency) enrichedField.currency = objectDefField.currency;
         if (objectDefField.precision !== undefined && enrichedField.precision === undefined) enrichedField.precision = objectDefField.precision;

packages/plugin-detail/src/DetailView.tsx

@@ -89,6 +89,9 @@ export const DetailView: React.FC<DetailViewProps> = ({
 
     if (dataSource && schema.objectName && schema.resourceId) {
       setLoading(true);
+      // Clear stale state when navigating between objects/records
+      setObjectSchema(null);
+      setData(null);
       const objectName = schema.objectName;
       const resourceId = schema.resourceId;
       const prefix = `${objectName}-`;
@@ -106,15 +109,17 @@ export const DetailView: React.FC<DetailViewProps> = ({
 
       schemaPromise.then((resolvedSchema) => {
         if (!isMounted) return;
-        if (resolvedSchema) {
-          setObjectSchema(resolvedSchema);
-        }
+        setObjectSchema(resolvedSchema);
 
         // Compute $expand from objectSchema
         const expandFields = buildExpandFields(resolvedSchema?.fields, allFields);
         const params = expandFields.length > 0 ? { $expand: expandFields } : undefined;
 
-        return dataSource.findOne(objectName, resourceId, params).then((result) => {
+        const findOnePromise = params
+          ? dataSource.findOne(objectName, resourceId, params)
+          : dataSource.findOne(objectName, resourceId);
+
+        return findOnePromise.then((result) => {
           if (!isMounted) return;
           if (result) {
             setData(result);
@@ -126,7 +131,10 @@ export const DetailView: React.FC<DetailViewProps> = ({
           const altId = resIdStr.startsWith(prefix)
             ? resIdStr.slice(prefix.length)   // strip prefix
             : `${prefix}${resIdStr}`;          // prepend prefix
-          return dataSource.findOne(objectName, altId, params).then((fallbackResult) => {
+          return (params
+            ? dataSource.findOne(objectName, altId, params)
+            : dataSource.findOne(objectName, altId)
+          ).then((fallbackResult) => {
             if (isMounted) {
               setData(fallbackResult);
               setLoading(false);

packages/plugin-detail/src/__tests__/DetailView.test.tsx

@@ -600,7 +600,8 @@ describe('DetailView', () => {
     render(<DetailView schema={schema} dataSource={mockDataSource} />);
 
     await waitFor(() => {
-      expect(mockDataSource.findOne).toHaveBeenCalledWith('contact', 'c1', undefined);
+      // When no lookup fields exist, findOne should be called without $expand params
+      expect(mockDataSource.findOne).toHaveBeenCalledWith('contact', 'c1');
     });
   });
 

packages/plugin-list/src/ListView.tsx

@@ -514,6 +514,9 @@ export const ListView: React.FC<ListViewProps> = ({
   // Fetch object definition
   React.useEffect(() => {
     let isMounted = true;
+    // Reset loaded flag so data fetch waits for the new schema
+    setObjectDefLoaded(false);
+    setObjectDef(null);
     const fetchObjectDef = async () => {
       if (!dataSource || !schema.objectName) {
         setObjectDefLoaded(true);