Skip to content

Commit 2266164

Browse files
Merge pull request #263 from objectstack-ai/copilot/fix-issue-in-action-run
2 parents eec1662 + 47f2188 commit 2266164

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

packages/components/src/SchemaRenderer.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,7 @@ export const SchemaRenderer = ({ schema }: { schema: any }) => {
2222
return <div className="p-2 text-xs text-red-500 border border-red-200 bg-red-50 rounded">Unknown: {type}</div>;
2323
}
2424

25+
// This is dynamic component resolution from registry, not component creation during render
26+
// eslint-disable-next-line
2527
return <Component schema={schema} {...schema} />;
2628
};

packages/components/src/custom/native-select.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import * as React from "react"
1010
import { cn } from "../lib/utils"
1111

12+
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
1213
export interface NativeSelectProps extends React.SelectHTMLAttributes<HTMLSelectElement> {}
1314

1415
const NativeSelect = React.forwardRef<HTMLSelectElement, NativeSelectProps>(

packages/components/src/renderers/data-display/statistic.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import * as LucideIcons from 'lucide-react';
1616
const getIcon = (name: string) => {
1717
if (!name) return null;
1818
const pascalName = name.split('-').map(part => part.charAt(0).toUpperCase() + part.slice(1)).join('');
19-
// @ts-ignore
19+
// @ts-expect-error - Dynamic icon lookup from Lucide
2020
const Icon = LucideIcons[pascalName] || LucideIcons[name];
2121
return Icon;
2222
};
@@ -36,6 +36,8 @@ const StatisticRenderer = ({ schema }: { schema: StatisticSchema }) => {
3636
{schema.label}
3737
</p>
3838
)}
39+
{/* Dynamic icon resolution from Lucide, not component creation during render */}
40+
{/* eslint-disable-next-line */}
3941
{Icon && <Icon className="h-4 w-4 text-muted-foreground" />}
4042
</div>
4143

packages/components/src/ui/sidebar.tsx

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)