|
| 1 | +/** |
| 2 | + * Tests for resolveRecordFormTarget — the modal-vs-page decision used by |
| 3 | + * `AppContent.handleEdit` when the user clicks "Create" or "Edit" on a |
| 4 | + * record. Covers: |
| 5 | + * - default (no editMode) → modal |
| 6 | + * - editMode: 'modal' → modal (explicit opt-out) |
| 7 | + * - editMode: 'page' + null/undefined record → create URL |
| 8 | + * - editMode: 'page' + record with id → edit URL |
| 9 | + * - editMode: 'page' + record with _id (Mongo-style) → edit URL |
| 10 | + * - URL encoding of record ids that contain reserved characters |
| 11 | + * - missing objectDef → modal (defensive fallback) |
| 12 | + */ |
| 13 | + |
| 14 | +import { describe, it, expect } from 'vitest'; |
| 15 | +import { |
| 16 | + resolveRecordFormTarget, |
| 17 | + resolveNavigateCreateUrl, |
| 18 | + resolveNavigateEditUrl, |
| 19 | +} from '../recordFormNavigation'; |
| 20 | + |
| 21 | +describe('resolveRecordFormTarget', () => { |
| 22 | + const baseUrl = '/apps/sales'; |
| 23 | + |
| 24 | + it('returns modal when editMode is unset (default)', () => { |
| 25 | + expect( |
| 26 | + resolveRecordFormTarget({ |
| 27 | + objectDef: { name: 'account' }, |
| 28 | + baseUrl, |
| 29 | + record: null, |
| 30 | + }), |
| 31 | + ).toEqual({ kind: 'modal' }); |
| 32 | + }); |
| 33 | + |
| 34 | + it('returns modal when editMode is explicitly "modal"', () => { |
| 35 | + expect( |
| 36 | + resolveRecordFormTarget({ |
| 37 | + objectDef: { name: 'account', editMode: 'modal' }, |
| 38 | + baseUrl, |
| 39 | + record: { id: 'r1' }, |
| 40 | + }), |
| 41 | + ).toEqual({ kind: 'modal' }); |
| 42 | + }); |
| 43 | + |
| 44 | + it('returns the create URL when editMode is "page" and no record is provided', () => { |
| 45 | + expect( |
| 46 | + resolveRecordFormTarget({ |
| 47 | + objectDef: { name: 'account', editMode: 'page' }, |
| 48 | + baseUrl, |
| 49 | + record: null, |
| 50 | + }), |
| 51 | + ).toEqual({ kind: 'page', url: '/apps/sales/account/new' }); |
| 52 | + }); |
| 53 | + |
| 54 | + it('returns the edit URL when editMode is "page" and record has id', () => { |
| 55 | + expect( |
| 56 | + resolveRecordFormTarget({ |
| 57 | + objectDef: { name: 'account', editMode: 'page' }, |
| 58 | + baseUrl, |
| 59 | + record: { id: 'r1' }, |
| 60 | + }), |
| 61 | + ).toEqual({ kind: 'page', url: '/apps/sales/account/record/r1/edit' }); |
| 62 | + }); |
| 63 | + |
| 64 | + it('falls back to record._id (Mongo-style) when id is missing', () => { |
| 65 | + expect( |
| 66 | + resolveRecordFormTarget({ |
| 67 | + objectDef: { name: 'account', editMode: 'page' }, |
| 68 | + baseUrl, |
| 69 | + record: { _id: 'mongo-7' }, |
| 70 | + }), |
| 71 | + ).toEqual({ kind: 'page', url: '/apps/sales/account/record/mongo-7/edit' }); |
| 72 | + }); |
| 73 | + |
| 74 | + it('URL-encodes record ids with reserved characters', () => { |
| 75 | + expect( |
| 76 | + resolveRecordFormTarget({ |
| 77 | + objectDef: { name: 'account', editMode: 'page' }, |
| 78 | + baseUrl, |
| 79 | + record: { id: 'a/b c' }, |
| 80 | + }), |
| 81 | + ).toEqual({ |
| 82 | + kind: 'page', |
| 83 | + url: '/apps/sales/account/record/a%2Fb%20c/edit', |
| 84 | + }); |
| 85 | + }); |
| 86 | + |
| 87 | + it('treats an empty-string id as create-mode', () => { |
| 88 | + expect( |
| 89 | + resolveRecordFormTarget({ |
| 90 | + objectDef: { name: 'account', editMode: 'page' }, |
| 91 | + baseUrl, |
| 92 | + record: { id: '' }, |
| 93 | + }), |
| 94 | + ).toEqual({ kind: 'page', url: '/apps/sales/account/new' }); |
| 95 | + }); |
| 96 | + |
| 97 | + it('treats numeric ids correctly', () => { |
| 98 | + expect( |
| 99 | + resolveRecordFormTarget({ |
| 100 | + objectDef: { name: 'account', editMode: 'page' }, |
| 101 | + baseUrl, |
| 102 | + record: { id: 42 }, |
| 103 | + }), |
| 104 | + ).toEqual({ kind: 'page', url: '/apps/sales/account/record/42/edit' }); |
| 105 | + }); |
| 106 | + |
| 107 | + it('returns modal when objectDef is missing (defensive fallback)', () => { |
| 108 | + expect( |
| 109 | + resolveRecordFormTarget({ |
| 110 | + objectDef: null, |
| 111 | + baseUrl, |
| 112 | + record: { id: 'r1' }, |
| 113 | + }), |
| 114 | + ).toEqual({ kind: 'modal' }); |
| 115 | + }); |
| 116 | + |
| 117 | + it('returns modal when objectDef has no name', () => { |
| 118 | + expect( |
| 119 | + resolveRecordFormTarget({ |
| 120 | + objectDef: { name: '', editMode: 'page' }, |
| 121 | + baseUrl, |
| 122 | + record: { id: 'r1' }, |
| 123 | + }), |
| 124 | + ).toEqual({ kind: 'modal' }); |
| 125 | + }); |
| 126 | +}); |
| 127 | + |
| 128 | +describe('resolveNavigateCreateUrl', () => { |
| 129 | + const defaultBaseUrl = '/apps/sales'; |
| 130 | + |
| 131 | + it('uses params.objectName as primary source', () => { |
| 132 | + expect( |
| 133 | + resolveNavigateCreateUrl({ |
| 134 | + action: { params: { objectName: 'lead' } }, |
| 135 | + defaultBaseUrl, |
| 136 | + }), |
| 137 | + ).toEqual({ success: true, url: '/apps/sales/lead/new' }); |
| 138 | + }); |
| 139 | + |
| 140 | + it('falls back to action.objectName when params.objectName is missing', () => { |
| 141 | + expect( |
| 142 | + resolveNavigateCreateUrl({ |
| 143 | + action: { objectName: 'lead' }, |
| 144 | + defaultBaseUrl, |
| 145 | + }), |
| 146 | + ).toEqual({ success: true, url: '/apps/sales/lead/new' }); |
| 147 | + }); |
| 148 | + |
| 149 | + it('falls back to context.objectName as last resort', () => { |
| 150 | + expect( |
| 151 | + resolveNavigateCreateUrl({ |
| 152 | + action: {}, |
| 153 | + context: { objectName: 'lead' }, |
| 154 | + defaultBaseUrl, |
| 155 | + }), |
| 156 | + ).toEqual({ success: true, url: '/apps/sales/lead/new' }); |
| 157 | + }); |
| 158 | + |
| 159 | + it('prefers context.baseUrl over defaultBaseUrl', () => { |
| 160 | + expect( |
| 161 | + resolveNavigateCreateUrl({ |
| 162 | + action: { params: { objectName: 'lead' } }, |
| 163 | + context: { baseUrl: '/apps/marketing' }, |
| 164 | + defaultBaseUrl, |
| 165 | + }), |
| 166 | + ).toEqual({ success: true, url: '/apps/marketing/lead/new' }); |
| 167 | + }); |
| 168 | + |
| 169 | + it('errors when objectName cannot be resolved', () => { |
| 170 | + expect( |
| 171 | + resolveNavigateCreateUrl({ |
| 172 | + action: {}, |
| 173 | + defaultBaseUrl, |
| 174 | + }), |
| 175 | + ).toEqual({ |
| 176 | + success: false, |
| 177 | + error: 'navigate_create: objectName is required', |
| 178 | + }); |
| 179 | + }); |
| 180 | +}); |
| 181 | + |
| 182 | +describe('resolveNavigateEditUrl', () => { |
| 183 | + const defaultBaseUrl = '/apps/sales'; |
| 184 | + |
| 185 | + it('builds the edit URL from params', () => { |
| 186 | + expect( |
| 187 | + resolveNavigateEditUrl({ |
| 188 | + action: { params: { objectName: 'lead', recordId: 'L-7' } }, |
| 189 | + defaultBaseUrl, |
| 190 | + }), |
| 191 | + ).toEqual({ success: true, url: '/apps/sales/lead/record/L-7/edit' }); |
| 192 | + }); |
| 193 | + |
| 194 | + it('falls back to action.objectName + action.recordId', () => { |
| 195 | + expect( |
| 196 | + resolveNavigateEditUrl({ |
| 197 | + action: { objectName: 'lead', recordId: 'L-7' }, |
| 198 | + defaultBaseUrl, |
| 199 | + }), |
| 200 | + ).toEqual({ success: true, url: '/apps/sales/lead/record/L-7/edit' }); |
| 201 | + }); |
| 202 | + |
| 203 | + it('uses context.objectName but never context.recordId', () => { |
| 204 | + // recordId must always come from the action — every record click |
| 205 | + // should provide its own id. |
| 206 | + expect( |
| 207 | + resolveNavigateEditUrl({ |
| 208 | + action: { params: { recordId: 'L-7' } }, |
| 209 | + context: { objectName: 'lead' }, |
| 210 | + defaultBaseUrl, |
| 211 | + }), |
| 212 | + ).toEqual({ success: true, url: '/apps/sales/lead/record/L-7/edit' }); |
| 213 | + }); |
| 214 | + |
| 215 | + it('URL-encodes record ids', () => { |
| 216 | + expect( |
| 217 | + resolveNavigateEditUrl({ |
| 218 | + action: { params: { objectName: 'lead', recordId: 'a/b c' } }, |
| 219 | + defaultBaseUrl, |
| 220 | + }), |
| 221 | + ).toEqual({ |
| 222 | + success: true, |
| 223 | + url: '/apps/sales/lead/record/a%2Fb%20c/edit', |
| 224 | + }); |
| 225 | + }); |
| 226 | + |
| 227 | + it('errors when objectName is missing', () => { |
| 228 | + expect( |
| 229 | + resolveNavigateEditUrl({ |
| 230 | + action: { params: { recordId: 'L-7' } }, |
| 231 | + defaultBaseUrl, |
| 232 | + }), |
| 233 | + ).toEqual({ |
| 234 | + success: false, |
| 235 | + error: 'navigate_edit: objectName and recordId are required', |
| 236 | + }); |
| 237 | + }); |
| 238 | + |
| 239 | + it('errors when recordId is missing', () => { |
| 240 | + expect( |
| 241 | + resolveNavigateEditUrl({ |
| 242 | + action: { params: { objectName: 'lead' } }, |
| 243 | + defaultBaseUrl, |
| 244 | + }), |
| 245 | + ).toEqual({ |
| 246 | + success: false, |
| 247 | + error: 'navigate_edit: objectName and recordId are required', |
| 248 | + }); |
| 249 | + }); |
| 250 | + |
| 251 | + it('errors when recordId is empty string', () => { |
| 252 | + expect( |
| 253 | + resolveNavigateEditUrl({ |
| 254 | + action: { params: { objectName: 'lead', recordId: '' } }, |
| 255 | + defaultBaseUrl, |
| 256 | + }), |
| 257 | + ).toEqual({ |
| 258 | + success: false, |
| 259 | + error: 'navigate_edit: objectName and recordId are required', |
| 260 | + }); |
| 261 | + }); |
| 262 | +}); |
0 commit comments