refactor: extract mergeViewsIntoObjects to shared utility in @object-ui/core

Address DRY concern from code review by extracting the adapter function
to packages/core/src/utils/merge-views-into-objects.ts. Both config files
now import from @object-ui/core instead of duplicating the function.

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

apps/console/objectstack.shared.ts

@@ -1,5 +1,6 @@
 import type { ObjectStackDefinition } from '@objectstack/spec';
 import { composeStacks } from '@objectstack/spec';
+import { mergeViewsIntoObjects } from '@object-ui/core';
 import crmConfigImport from '@object-ui/example-crm/objectstack.config';
 import todoConfigImport from '@object-ui/example-todo/objectstack.config';
 import kitchenSinkConfigImport from '@object-ui/example-kitchen-sink/objectstack.config';
@@ -13,29 +14,6 @@ function resolveDefault<T>(mod: MaybeDefault<T>): T {
   return mod as T;
 }
 
-// ---------------------------------------------------------------------------
-// Adapter: merge stack-level views (views[].listViews) into object definitions.
-// The runtime reads listViews from each object; this bridges the gap until
-// the runtime/provider layer handles it natively.
-// ---------------------------------------------------------------------------
-function mergeViewsIntoObjects(objects: any[], views: any[]): any[] {
-  const viewsByObject: Record<string, Record<string, any>> = {};
-  for (const view of views) {
-    if (!view.listViews) continue;
-    for (const [viewName, listView] of Object.entries(view.listViews as Record<string, any>)) {
-      const objectName = listView?.data?.object;
-      if (!objectName) continue;
-      if (!viewsByObject[objectName]) viewsByObject[objectName] = {};
-      viewsByObject[objectName][viewName] = listView;
-    }
-  }
-  return objects.map((obj: any) => {
-    const v = viewsByObject[obj.name];
-    if (!v) return obj;
-    return { ...obj, listViews: { ...(obj.listViews || {}), ...v } };
-  });
-}
-
 const crmConfig = resolveDefault<ObjectStackDefinition>(crmConfigImport);
 const todoConfig = resolveDefault<ObjectStackDefinition>(todoConfigImport);
 const kitchenSinkConfig = resolveDefault<ObjectStackDefinition>(kitchenSinkConfigImport);

objectstack.config.ts

@@ -20,33 +20,11 @@ import { InMemoryDriver } from '@objectstack/driver-memory';
 import { HonoServerPlugin } from '@objectstack/plugin-hono-server';
 import { ConsolePlugin } from '@object-ui/console';
 import { composeStacks } from '@objectstack/spec';
+import { mergeViewsIntoObjects } from '@object-ui/core';
 import { CRMPlugin } from './examples/crm/plugin';
 import { TodoPlugin } from './examples/todo/plugin';
 import { KitchenSinkPlugin } from './examples/kitchen-sink/plugin';
 
-// ---------------------------------------------------------------------------
-// Adapter: merge stack-level views (views[].listViews) into object definitions.
-// The runtime reads listViews from each object; this bridges the gap until
-// the runtime/provider layer handles it natively.
-// ---------------------------------------------------------------------------
-function mergeViewsIntoObjects(objects: any[], views: any[]): any[] {
-  const viewsByObject: Record<string, Record<string, any>> = {};
-  for (const view of views) {
-    if (!view.listViews) continue;
-    for (const [viewName, listView] of Object.entries(view.listViews as Record<string, any>)) {
-      const objectName = listView?.data?.object;
-      if (!objectName) continue;
-      if (!viewsByObject[objectName]) viewsByObject[objectName] = {};
-      viewsByObject[objectName][viewName] = listView;
-    }
-  }
-  return objects.map((obj: any) => {
-    const v = viewsByObject[obj.name];
-    if (!v) return obj;
-    return { ...obj, listViews: { ...(obj.listViews || {}), ...v } };
-  });
-}
-
 // Instantiate example plugins
 const plugins = [new CRMPlugin(), new TodoPlugin(), new KitchenSinkPlugin()];
 

packages/core/src/index.ts

@@ -26,4 +26,5 @@ export * from './data-scope/index.js';
 export * from './errors/index.js';
 export * from './utils/debug.js';
 export * from './utils/debug-collector.js';
+export * from './utils/merge-views-into-objects.js';
 export * from './protocols/index.js';

packages/core/src/utils/merge-views-into-objects.ts

@@ -0,0 +1,28 @@
+/**
+ * Adapter: merge stack-level views into object definitions.
+ *
+ * Views are defined at the stack level (views[].listViews) but the runtime
+ * expects listViews on each object definition. This bridges the gap until
+ * the runtime/provider layer handles it natively.
+ *
+ * @param objects - Object definitions from composed stack
+ * @param views   - View definitions containing listViews keyed by object name
+ * @returns Objects with listViews merged in from matching views
+ */
+export function mergeViewsIntoObjects(objects: any[], views: any[]): any[] {
+  const viewsByObject: Record<string, Record<string, any>> = {};
+  for (const view of views) {
+    if (!view.listViews) continue;
+    for (const [viewName, listView] of Object.entries(view.listViews as Record<string, any>)) {
+      const objectName = listView?.data?.object;
+      if (!objectName) continue;
+      if (!viewsByObject[objectName]) viewsByObject[objectName] = {};
+      viewsByObject[objectName][viewName] = listView;
+    }
+  }
+  return objects.map((obj: any) => {
+    const v = viewsByObject[obj.name];
+    if (!v) return obj;
+    return { ...obj, listViews: { ...(obj.listViews || {}), ...v } };
+  });
+}