Merge pull request #296 from objectstack-ai/copilot/fix-issue-in-object-ui

Author: hotlong

packages/components/vite.config.ts

@@ -46,6 +46,7 @@ export default defineConfig({
     globals: true,
     environment: 'happy-dom',
     setupFiles: ['../../vitest.setup.ts'],
+    passWithNoTests: true,
     // Ensure dependencies are resolved properly for tests
     deps: {
       inline: ['@object-ui/core', '@object-ui/react'],

packages/core/src/registry/Registry.ts

@@ -72,6 +72,14 @@ export class Registry<T = any> {
   register(type: string, component: ComponentRenderer<T>, meta?: ComponentMeta) {
     const fullType = meta?.namespace ? `${meta.namespace}:${type}` : type;
 
+    // Warn if registering without namespace (deprecated pattern)
+    if (!meta?.namespace) {
+      console.warn(
+        `Registering component "${type}" without a namespace is deprecated. ` +
+        `Please provide a namespace in the meta parameter.`
+      );
+    }
+    
     if (this.components.has(fullType)) {
       // console.warn(`Component type "${fullType}" is already registered. Overwriting.`);
     }
@@ -84,7 +92,9 @@ export class Registry<T = any> {
 
     // Also register without namespace for backward compatibility
     // This allows "button" to work even when registered as "ui:button"
-    if (meta?.namespace && !this.components.has(type)) {
+    // Note: If multiple namespaced components share the same short name,
+    // the last registration wins for non-namespaced lookups
+    if (meta?.namespace) {
       this.components.set(type, {
         type: fullType, // Keep reference to namespaced type
         component,
@@ -113,16 +123,13 @@ export class Registry<T = any> {
    * registry.get('button', 'ui') // Tries 'ui:button' first, then 'button'
    */
   get(type: string, namespace?: string): ComponentRenderer<T> | undefined {
-    // Try namespaced lookup first if namespace provided
+    // If namespace is explicitly provided, ONLY look in that namespace (no fallback)
     if (namespace) {
       const namespacedType = `${namespace}:${type}`;
-      const namespacedComponent = this.components.get(namespacedType);
-      if (namespacedComponent) {
-        return namespacedComponent.component;
-      }
+      return this.components.get(namespacedType)?.component;
     }
 
-    // Fallback to direct type lookup
+    // When no namespace provided, use backward compatibility lookup
     return this.components.get(type)?.component;
   }
 
@@ -134,16 +141,13 @@ export class Registry<T = any> {
    * @returns Component configuration or undefined
    */
   getConfig(type: string, namespace?: string): ComponentConfig<T> | undefined {
-    // Try namespaced lookup first if namespace provided
+    // If namespace is explicitly provided, ONLY look in that namespace (no fallback)
     if (namespace) {
       const namespacedType = `${namespace}:${type}`;
-      const namespacedConfig = this.components.get(namespacedType);
-      if (namespacedConfig) {
-        return namespacedConfig;
-      }
+      return this.components.get(namespacedType);
     }
 
-    // Fallback to direct type lookup
+    // When no namespace provided, use backward compatibility lookup
     return this.components.get(type);
   }
 
@@ -155,12 +159,12 @@ export class Registry<T = any> {
    * @returns True if component is registered
    */
   has(type: string, namespace?: string): boolean {
+    // If namespace is explicitly provided, ONLY look in that namespace (no fallback)
     if (namespace) {
       const namespacedType = `${namespace}:${type}`;
-      if (this.components.has(namespacedType)) {
-        return true;
-      }
+      return this.components.has(namespacedType);
     }
+    // When no namespace provided, use backward compatibility lookup
     return this.components.has(type);
   }
 

packages/core/src/registry/__tests__/PluginSystem.test.ts

@@ -28,7 +28,8 @@ describe('PluginSystem', () => {
       }
     };
 
-    await pluginSystem.loadPlugin(plugin, registry);
+    // Use legacy mode (useScope: false) to test direct registry access
+    await pluginSystem.loadPlugin(plugin, registry, false);
 
     expect(pluginSystem.isLoaded('test-plugin')).toBe(true);
     expect(pluginSystem.getLoadedPlugins()).toContain('test-plugin');
@@ -201,7 +202,8 @@ describe('PluginSystem', () => {
       register: registerFn
     };
 
-    await pluginSystem.loadPlugin(plugin, registry);
+    // Use legacy mode (useScope: false) to verify the raw Registry is passed
+    await pluginSystem.loadPlugin(plugin, registry, false);
 
     expect(registerFn).toHaveBeenCalledWith(registry);
     expect(registerFn).toHaveBeenCalledTimes(1);

packages/fields/vite.config.ts

@@ -45,5 +45,6 @@ export default defineConfig({
     globals: true,
     environment: 'happy-dom',
     setupFiles: ['../../vitest.setup.ts'],
+    passWithNoTests: true,
   },
 });

packages/layout/vite.config.ts

@@ -32,4 +32,7 @@ export default defineConfig({
       ],
     },
   },
+  test: {
+    passWithNoTests: true,
+  },
 });

packages/plugin-aggrid/vite.config.ts

@@ -47,4 +47,7 @@ export default defineConfig({
       },
     },
   },
+  test: {
+    passWithNoTests: true,
+  },
 });

packages/plugin-calendar/vite.config.ts

@@ -47,4 +47,7 @@ export default defineConfig({
       },
     },
   },
+  test: {
+    passWithNoTests: true,
+  },
 });

packages/plugin-charts/vite.config.ts

@@ -45,4 +45,7 @@ export default defineConfig({
       },
     },
   },
+  test: {
+    passWithNoTests: true,
+  },
 });

packages/plugin-chatbot/vite.config.ts

@@ -46,4 +46,7 @@ export default defineConfig({
       },
     },
   },
+  test: {
+    passWithNoTests: true,
+  },
 });

packages/plugin-dashboard/vite.config.ts

@@ -41,4 +41,7 @@ export default defineConfig({
       },
     },
   },
+  test: {
+    passWithNoTests: true,
+  },
 });