fix(page,field): consume the spec's type/label/maxLength keys (framework#1878 §3 recheck) (#2867)

Three forward-drifts where objectui read a different key than the spec
declares, so authoring the documented key silently no-oped:

- page `type` -> `pageType`: PageSchema declares the page KIND as `type`;
  PageRenderer reads `schema.pageType` with a 'record' fallback and NOTHING
  mapped between them, so every non-record page (home/app/list/utility)
  rendered with the record max-width, a wrong data-page-type and a
  suppressed header. PageView now passes pageType alongside the SchemaNode
  discriminator `type` (which must stay -- ComponentRegistry dispatches on it).
- page `label` -> `title`: PageSchema.label is required but the region
  renderer read only `title`. Dual-reads now, mirroring DashboardRenderer.
  Coupled with the above: the header is gated on pageType !== 'record', so
  fixing label alone would still render nothing.
- field maxLength/minLength: validation already dual-read them, but
  ObjectForm's HTML-attribute pass and TextAreaField read max_length only --
  no browser cap, no character counter for spec-authored metadata.

Browser-verified against the showcase: capability_map (type:'home') now
renders data-page-type="home", max-w-screen-2xl and its title; record pages
unchanged. 625 tests green across the touched packages.

Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Author: os-zhuang

.changeset/naming-drift-page-and-maxlength.md

@@ -0,0 +1,31 @@
+---
+"@object-ui/app-shell": patch
+"@object-ui/components": patch
+"@object-ui/plugin-form": patch
+"@object-ui/fields": patch
+---
+
+fix(page,field): consume the spec's `type`/`label`/`maxLength` keys (framework#1878 §3 naming-drift recheck)
+
+Three forward-drifts where objectui read a different key than the spec
+declares, so authoring the documented key silently no-oped:
+
+- **page `type` → `pageType`** (app-shell + components): `PageSchema` declares
+  the page KIND as `type`, but `PageRenderer` reads `schema.pageType` and fell
+  back to `'record'` — and nothing mapped between them. Every non-record page
+  (`home`/`app`/`list`/`utility`) rendered with the record max-width, a wrong
+  `data-page-type` attribute, and a suppressed header. `PageView` now passes
+  `pageType` alongside the SchemaNode discriminator `type`.
+- **page `label` → `title`** (components): `PageSchema.label` is required but the
+  region renderer read only `title`. Now dual-reads `title ?? label`, mirroring
+  the fallback `DashboardRenderer` already uses. Coupled with the above — the
+  header is gated on `pageType !== 'record'`, so both were needed for a title to
+  appear.
+- **field `maxLength`/`minLength`** (plugin-form + fields): validation already
+  dual-read these, but `ObjectForm`'s HTML-attribute pass and `TextAreaField`
+  read `max_length` only, so a spec-authored `maxLength` gave no browser cap and
+  no character counter. Both now dual-read, matching `buildValidationRules`.
+
+Verified in the browser against the showcase: `capability_map` (`type: 'home'`)
+now renders `data-page-type="home"`, the `home` max-width and its page title;
+record pages are unchanged.

packages/app-shell/src/views/PageView.tsx

@@ -120,7 +120,15 @@ export function PageView() {
               key={refreshKey}
               schema={{
                 ...page,
+                // `type` stays the SchemaNode discriminator ComponentRegistry
+                // dispatches on. The spec's page KIND (`record|home|app|utility|
+                // list`) rides `pageType`, which PageRenderer reads — without
+                // this mapping every page fell back to `pageType: 'record'`,
+                // so non-record pages got the record max-width, a wrong
+                // `data-page-type` and a suppressed header (framework#1878 §3
+                // naming-drift recheck).
                 type: (page as any).type || 'page',
+                pageType: (page as any).type,
                 context: { ...(page as any).context, params, refreshKey },
               }}
             />

packages/components/src/renderers/layout/page.tsx

@@ -389,6 +389,10 @@ export const PageRenderer: React.FC<{
   [key: string]: any;
 }> = ({ schema, className, ...props }) => {
   const pageType = schema.pageType || 'record';
+  // Spec PageSchema declares `label` (required); `title` is the objectui
+  // spelling. Dual-read so a spec-authored page still renders its header
+  // (framework#1878 §3 naming-drift recheck).
+  const pageTitle = schema.title ?? (schema as any).label;
 
   // Extract designer-related props and strip schema-only metadata that
   // would otherwise leak onto the wrapper <div> as invalid HTML attributes
@@ -499,12 +503,15 @@ export const PageRenderer: React.FC<{
     >
       <div className={cn(fullBleed ? 'space-y-6' : 'mx-auto space-y-6', maxWidthClass)}>
         {/* Page header — suppressed on record pages (the page:header component
-            in the header region renders the record-bound title instead). */}
-        {pageType !== 'record' && (schema.title || schema.description) && (
+            in the header region renders the record-bound title instead).
+            `title` is the objectui spelling; the spec's PageSchema declares
+            `label` (required), so dual-read it — mirrors the fallback
+            DashboardRenderer already uses (framework#1878 §3 recheck). */}
+        {pageType !== 'record' && (pageTitle || schema.description) && (
           <div className="space-y-2">
-            {schema.title && (
+            {pageTitle && (
               <h1 className="text-3xl font-bold tracking-tight text-foreground">
-                {schema.title}
+                {pageTitle}
               </h1>
             )}
             {schema.description && (

packages/fields/src/widgets/TextAreaField.tsx

@@ -36,7 +36,10 @@ export function TextAreaField({ value, onChange, field, readonly, errorMessage,
 
   const textareaField = (field || (props as any).schema) as any;
   const rows = textareaField?.rows || 4;
-  const maxLength = textareaField?.max_length;
+  // Spec FieldSchema declares camelCase `maxLength`; `max_length` is the legacy
+  // objectui spelling. Dual-read (framework#1878 §3 recheck) — without this a
+  // spec-authored maxLength gave neither the textarea cap nor the counter.
+  const maxLength = textareaField?.maxLength ?? textareaField?.max_length;
   // Mobile fullscreen flag may arrive on the field metadata, on the form-field
   // schema (when called via the form renderer where `field` is the ObjectQL
   // metadata sub-object), or as an explicit widget prop.

packages/plugin-form/src/ObjectForm.tsx

@@ -604,8 +604,12 @@ const SimpleObjectForm: React.FC<ObjectFormProps> = ({
         }
 
         if (field.type === 'text' || field.type === 'textarea' || field.type === 'markdown' || field.type === 'html') {
-          formField.maxLength = field.max_length;
-          formField.minLength = field.min_length;
+          // Spec FieldSchema declares camelCase; `max_length`/`min_length` is
+          // the legacy objectui spelling. Dual-read like buildValidationRules
+          // already does (framework#1878 §3 recheck) — without this a
+          // spec-authored `maxLength` never reached the HTML maxlength cap.
+          formField.maxLength = (field as any).maxLength ?? field.max_length;
+          formField.minLength = (field as any).minLength ?? field.min_length;
         }
 
         if (field.type === 'file' || field.type === 'image') {