refactor: extract isObjectProvider to shared utils, rename _dropped to _data

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

packages/plugin-dashboard/src/DashboardGridLayout.tsx

@@ -5,6 +5,7 @@ import { cn, Card, CardHeader, CardTitle, CardContent, Button } from '@object-ui
 import { Edit, GripVertical, Save, X, RefreshCw } from 'lucide-react';
 import { SchemaRenderer, useHasDndProvider, useDnd } from '@object-ui/react';
 import type { DashboardSchema, DashboardWidgetSchema } from '@object-ui/types';
+import { isObjectProvider } from './utils';
 
 /** Bridges editMode transitions to the ObjectUI DnD system when a DndProvider is present. */
 function DndEditModeBridge({ editMode }: { editMode: boolean }) {
@@ -30,16 +31,6 @@ const CHART_COLORS = [
   'hsl(var(--chart-5))',
 ];
 
-/** Returns true when the widget data config uses provider: 'object' (async data source). */
-function isObjectProvider(widgetData: unknown): widgetData is { provider: 'object'; object?: string; aggregate?: any } {
-  return (
-    widgetData != null &&
-    typeof widgetData === 'object' &&
-    !Array.isArray(widgetData) &&
-    (widgetData as any).provider === 'object'
-  );
-}
-
 export interface DashboardGridLayoutProps {
   schema: DashboardSchema;
   className?: string;
@@ -176,7 +167,7 @@ export const DashboardGridLayout: React.FC<DashboardGridLayoutProps> = ({
 
       // provider: 'object' — pass through object config for async data loading
       if (isObjectProvider(widgetData)) {
-        const { data: _dropped, ...restOptions } = options;
+        const { data: _data, ...restOptions } = options;
         return {
           type: 'data-table',
           ...restOptions,
@@ -204,7 +195,7 @@ export const DashboardGridLayout: React.FC<DashboardGridLayoutProps> = ({
 
       // provider: 'object' — pass through object config for async data loading
       if (isObjectProvider(widgetData)) {
-        const { data: _dropped, ...restOptions } = options;
+        const { data: _data, ...restOptions } = options;
         return {
           type: 'pivot',
           ...restOptions,

packages/plugin-dashboard/src/DashboardRenderer.tsx

@@ -11,6 +11,7 @@ import { SchemaRenderer } from '@object-ui/react';
 import { cn, Card, CardHeader, CardTitle, CardContent, Button } from '@object-ui/components';
 import { forwardRef, useState, useEffect, useCallback, useRef } from 'react';
 import { RefreshCw } from 'lucide-react';
+import { isObjectProvider } from './utils';
 
 // Color palette for charts
 const CHART_COLORS = [
@@ -21,16 +22,6 @@ const CHART_COLORS = [
   'hsl(var(--chart-5))',
 ];
 
-/** Returns true when the widget data config uses provider: 'object' (async data source). */
-function isObjectProvider(widgetData: unknown): widgetData is { provider: 'object'; object?: string; aggregate?: any } {
-  return (
-    widgetData != null &&
-    typeof widgetData === 'object' &&
-    !Array.isArray(widgetData) &&
-    (widgetData as any).provider === 'object'
-  );
-}
-
 export interface DashboardRendererProps {
   schema: DashboardSchema;
   className?: string;
@@ -164,7 +155,7 @@ export const DashboardRenderer = forwardRef<HTMLDivElement, DashboardRendererPro
 
                 // provider: 'object' — pass through object config for async data loading
                 if (isObjectProvider(widgetData)) {
-                    const { data: _dropped, ...restOptions } = options;
+                    const { data: _data, ...restOptions } = options;
                     return {
                         type: 'data-table',
                         ...restOptions,
@@ -192,7 +183,7 @@ export const DashboardRenderer = forwardRef<HTMLDivElement, DashboardRendererPro
 
                 // provider: 'object' — pass through object config for async data loading
                 if (isObjectProvider(widgetData)) {
-                    const { data: _dropped, ...restOptions } = options;
+                    const { data: _data, ...restOptions } = options;
                     return {
                         type: 'pivot',
                         ...restOptions,

packages/plugin-dashboard/src/utils.ts

@@ -0,0 +1,17 @@
+/**
+ * ObjectUI
+ * Copyright (c) 2024-present ObjectStack Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+/** Returns true when the widget data config uses provider: 'object' (async data source). */
+export function isObjectProvider(widgetData: unknown): widgetData is { provider: 'object'; object?: string; aggregate?: any } {
+  return (
+    widgetData != null &&
+    typeof widgetData === 'object' &&
+    !Array.isArray(widgetData) &&
+    (widgetData as any).provider === 'object'
+  );
+}